From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kvm tools: mmap guest kernel instead of reading it into
  memory
Date: Mon, 12 Dec 2011 18:18:23 +0100
Message-ID: <20111212171822.GA23870@elte.hu>
References: <1323701258-17443-1-git-send-email-levinsasha928@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: penberg@kernel.org, gorcunov@gmail.com, asias.hejun@gmail.com,
	kvm@vger.kernel.org, ajsween@sandia.gov
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:37605 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753227Ab1LLRUH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 12 Dec 2011 12:20:07 -0500
Content-Disposition: inline
In-Reply-To: <1323701258-17443-1-git-send-email-levinsasha928@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Sasha Levin <levinsasha928@gmail.com> wrote:

> +	kvm->bz_start = mmap(NULL, kvm->bz_len, PROT_READ | PROT_WRITE,
> +				MAP_PRIVATE, kvm->bz_fd, setup_end);
>  
> +	/* NOP everything before the kernel start */
> +	memset(kvm->bz_start, 0x90, setup_size - setup_end);

You should really, really think about the case where mmap() 
fails.

Thanks,

	Ingo