All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
	Andrew Vagin <avagin@openvz.org>,
	Serge Hallyn <serge.hallyn@canonical.com>,
	Vasiliy Kulikov <segoon@openwall.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Pavel Emelyanov <xemul@parallels.com>,
	Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [patch 3/3] [PATCH] prctl: Add PR_SET_MM codes to set up mm_struct entires v3
Date: Tue, 13 Dec 2011 02:01:32 +0400	[thread overview]
Message-ID: <20111212220132.GT2199@moon> (raw)
In-Reply-To: <20111212135323.2f757d9b.akpm@linux-foundation.org>

On Mon, Dec 12, 2011 at 01:53:23PM -0800, Andrew Morton wrote:
...
> >
> > +#ifdef CONFIG_CHECKPOINT_RESTORE
> > +static int prctl_set_mm(int opt, unsigned long addr,
> > +			unsigned long arg4, unsigned long arg5)
> > +{
> > +	unsigned long rlim = rlimit(RLIMIT_DATA);
> > +	unsigned long vm_req_flags;
> > +	unsigned long vm_bad_flags;
> > +	struct vm_area_struct *vma;
> > +	int error = 0;
> > +
> > +	if (arg4 | arg5)
> > +		return -EINVAL;
> > +
> > +	if (!capable(CAP_SYS_ADMIN))
> > +		return -EPERM;
> > +
> > +	if (addr >= TASK_SIZE)
> > +		return -EINVAL;
> > +
> > +	down_read(&current->mm->mmap_sem);
> 
> This may not be true of all compiler versions, but when I cache
> current->mm in a local, the code size is reduced rather a lot:
> 
> akpm:/usr/src/25> size kernel/sys.o
>    text    data     bss     dec     hex filename
>   22685   14376    7616   44677    ae85 kernel/sys.o
>   22489   14376    7616   44481    adc1 kernel/sys.o
> 

Hmm, this is great and weird. Letme try...

	Cyrill

  reply	other threads:[~2011-12-12 22:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 20:06 [patch 0/3] Patches in a sake of checkpoint/restore, procfs and prctls Cyrill Gorcunov
2011-12-12 20:06 ` [patch 1/3] Kconfig: Introduce CHECKPOINT_RESTORE symbol Cyrill Gorcunov
2011-12-12 20:40   ` Kees Cook
2011-12-12 20:06 ` [patch 2/3] [PATCH] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat v4 Cyrill Gorcunov
2011-12-12 20:06 ` [patch 3/3] [PATCH] prctl: Add PR_SET_MM codes to set up mm_struct entires v3 Cyrill Gorcunov
2011-12-12 20:38   ` Kees Cook
2011-12-12 20:51     ` Cyrill Gorcunov
2011-12-12 21:53       ` Andrew Morton
2011-12-12 22:01         ` Cyrill Gorcunov [this message]
2011-12-12 22:05           ` Cyrill Gorcunov
2011-12-12 21:49   ` KOSAKI Motohiro
2011-12-12 21:58     ` Cyrill Gorcunov
2011-12-12 22:24       ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111212220132.GT2199@moon \
    --to=gorcunov@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=segoon@openwall.com \
    --cc=serge.hallyn@canonical.com \
    --cc=tj@kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.