From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pBCMgUV5126065 for ; Mon, 12 Dec 2011 16:42:30 -0600 Received: from newverein.lst.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5E93916F0224 for ; Mon, 12 Dec 2011 14:42:29 -0800 (PST) Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by cuda.sgi.com with ESMTP id bn2FZItXzUNIDWoX for ; Mon, 12 Dec 2011 14:42:29 -0800 (PST) Date: Mon, 12 Dec 2011 23:42:27 +0100 From: Christoph Hellwig Subject: Re: [PATCH] xfs: fix acl count validation in xfs_acl_from_disk() Message-ID: <20111212224227.GA17461@lst.de> References: <1323726952-22963-1-git-send-email-xi.wang@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1323726952-22963-1-git-send-email-xi.wang@gmail.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Xi Wang Cc: linux-kernel@vger.kernel.org, Ben Myers , Christoph Hellwig , xfs@oss.sgi.com On Mon, Dec 12, 2011 at 04:55:52PM -0500, Xi Wang wrote: > Commit fa8b18ed didn't prevent the integer overflow and possible > memory corruption. "count" can go negative and bypass the check. Thanks, this looks good to me. Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754581Ab1LLWma (ORCPT ); Mon, 12 Dec 2011 17:42:30 -0500 Received: from verein.lst.de ([213.95.11.211]:47654 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754558Ab1LLWm3 (ORCPT ); Mon, 12 Dec 2011 17:42:29 -0500 Date: Mon, 12 Dec 2011 23:42:27 +0100 From: Christoph Hellwig To: Xi Wang Cc: Christoph Hellwig , Ben Myers , xfs@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xfs: fix acl count validation in xfs_acl_from_disk() Message-ID: <20111212224227.GA17461@lst.de> References: <1323726952-22963-1-git-send-email-xi.wang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1323726952-22963-1-git-send-email-xi.wang@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 12, 2011 at 04:55:52PM -0500, Xi Wang wrote: > Commit fa8b18ed didn't prevent the integer overflow and possible > memory corruption. "count" can go negative and bypass the check. Thanks, this looks good to me. Reviewed-by: Christoph Hellwig