From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] staging: drm/omap: fix for connectors not enabled at bootup Date: Mon, 12 Dec 2011 16:39:05 -0800 Message-ID: <20111213003905.GA3935@kroah.com> References: <1323637997-18045-1-git-send-email-rob.clark@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from out2.smtp.messagingengine.com (out2.smtp.messagingengine.com [66.111.4.26]) by gabe.freedesktop.org (Postfix) with ESMTP id 275859E7B4 for ; Mon, 12 Dec 2011 16:39:43 -0800 (PST) Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 99A4922846 for ; Mon, 12 Dec 2011 19:39:42 -0500 (EST) Content-Disposition: inline In-Reply-To: <1323637997-18045-1-git-send-email-rob.clark@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: Rob Clark , dri-devel@lists.freedesktop.org, patches@linaro.org List-Id: dri-devel@lists.freedesktop.org On Sun, Dec 11, 2011 at 03:13:17PM -0600, Rob Clark wrote: > From: Rob Clark > > The connector's dpms fxn is only triggered by userspace. When the > driver is loaded and detected displays configured, drm core only > calls the crtc and encoder's dpms functions. > > Signed-off-by: Rob Clark > --- > Arguably, this could be called a work-around, and instead drm core > should call connector's dpms functions and rely on > drm_helper_connector_dpms to call encoder and crtc dpms functions. > If people think it is better to fix this in drm core, and don't > mind me making that change, then I will do that instead. Sounds like you should do that in the drm core itself, so I'll not queue up this patch for now. thanks, greg k-h