From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/2] drivers/mtd: add a core
Date: Tue, 13 Dec 2011 12:11:04 +0100 [thread overview]
Message-ID: <20111213111104.GP27267@pengutronix.de> (raw)
In-Reply-To: <87zkewycio.fsf@free.fr>
On Tue, Dec 13, 2011 at 11:46:55AM +0100, Robert Jarzmik wrote:
> Sascha Hauer <s.hauer@pengutronix.de> writes:
>
> > So if no protests from other side come we can:
> >
> > - git mv drivers/mtd/nand/nand.c drivers/mtd/core.c
> > - replace the oob device with the data+oob device
> > - apply whatever other fixes you need
> Sure, that would be great.
> If no one complains in the next 5 days, I'll provide a V2 of the patch doing it
> your way :
> - patch1: move nand.c into core.c
> - patch2: convert all existing nand devices to core.c (ie. add_mtd_device)
> *Warning* The device will be named "/dev/mtd<N>" and not "/dev/nand<N>". This
> can break things, especially if legacy board code relies on the "nand" device
> naming. Solutions:
> (a) Add a parameter to add_mtd_device: add_mtd_device(struct mtd_info *mtd,
> char *basename)
> => if basename == NULL, then use "mtd"
> => if basename != NULL, use basename for device name
> (b) Create a specialized add_nand_device()
> (c) Convert all legacy boards from "nand" to "mtd"
> - patch3: amend core.c to bring in the device+oob function
>
> Does it look good to you ?
Yeah, sounds good.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-12-13 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 17:14 [PATCH 0/2] drivers/mtd: add a core Robert Jarzmik
2011-12-12 17:14 ` [PATCH 1/2] drivers/mtd: introduce {add,del}_nand_device Robert Jarzmik
2011-12-12 17:14 ` [PATCH 2/2] drivers/mtd: add a core mtd handler Robert Jarzmik
2011-12-13 9:21 ` [PATCH 0/2] drivers/mtd: add a core Sascha Hauer
2011-12-13 10:46 ` Robert Jarzmik
2011-12-13 11:11 ` Sascha Hauer [this message]
2011-12-13 10:51 ` Robert Jarzmik
2011-12-13 11:29 ` Sascha Hauer
2011-12-13 12:35 ` Robert Jarzmik
2011-12-13 18:58 ` Sascha Hauer
2011-12-14 10:01 ` Robert Jarzmik
2011-12-14 11:02 ` Sascha Hauer
2011-12-14 14:20 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213111104.GP27267@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.