From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Nallasellan, Singaravelan" <singaravelan.nallasellan@intel.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Vinod Koul <vinod.koul@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@ti.com" <lrg@ti.com>
Subject: Re: [PATCH v4 4/6] core: add API header and driver header files
Date: Tue, 13 Dec 2011 20:51:35 +0800 [thread overview]
Message-ID: <20111213125134.GM7148@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <3CA6C6D9F70D314CA34352990B57DA1507CCB50B02@bgsmsx502.gar.corp.intel.com>
On Tue, Dec 13, 2011 at 06:19:49PM +0530, Nallasellan, Singaravelan wrote:
> > +struct snd_compr_runtime {
> > + snd_pcm_state_t state;
> > + struct snd_compr_ops *ops;
> > + void *buffer;
> Can we define buffer as char *?
Clearly we *can* but why would we want to do that for a pointer to
unstructured data?
> > + size_t buffer_size;
> > + size_t fragment_size;
> Can we define buffer_size and fragment_size as unsigned items?
> Can we have negative size here?
Again, what is the advantage in doing this?
next prev parent reply other threads:[~2011-12-13 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 12:49 [PATCH v4 4/6] core: add API header and driver header files Nallasellan, Singaravelan
2011-12-13 12:51 ` Mark Brown [this message]
2011-12-13 13:02 ` Nallasellan, Singaravelan
2011-12-13 13:23 ` Takashi Iwai
2011-12-13 13:51 ` Nallasellan, Singaravelan
2011-12-13 14:04 ` Takashi Iwai
2011-12-13 14:24 ` Vinod Koul
2011-12-13 15:01 ` Takashi Iwai
2011-12-13 17:46 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2011-12-05 7:39 [PATCH v3 0/6] core: add compress data API to ALSA kernel Vinod Koul
2011-12-13 9:02 ` [PATCH v4 4/6] core: add API header and driver header files Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213125134.GM7148@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=singaravelan.nallasellan@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.