From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files v2
Date: Wed, 14 Dec 2011 02:22:56 +0400 [thread overview]
Message-ID: <20111213222256.GD2618@moon> (raw)
In-Reply-To: <1323812733-7520-1-git-send-email-andi@firstfloor.org>
On Tue, Dec 13, 2011 at 01:45:32PM -0800, Andi Kleen wrote:
>
> +/*
> + * Created parents stay around later. Sorry, but it shouldn't be a big issue.
> + */
> +static const char *create_parents(const char *name, struct dentry *parent,
> + struct dentry **pp, int *ref)
> +{
> + char fn[strlen(name) + 1];
> + char *tail;
> + char *s, *p;
> + struct dentry *new_parent, *dentry, *old_parent = NULL;
> +
> + strcpy(fn, name);
> + tail = strrchr(fn, '/');
> + if (!tail)
> + return name;
> + tail++;
> +
Hi Andi, is it possible to do say kstrdup or something instead of
variable-size array in fn[strlen(name) + 1] ? As far as I remember
we already had some warnings with them at least in perf land (or
trace land). Or I miss something?
Cyrill
next prev parent reply other threads:[~2011-12-13 22:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 21:45 [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files v2 Andi Kleen
2011-12-13 21:45 ` [PATCH 2/3] DEBUGFS: Add per cpu counters Andi Kleen
2011-12-13 22:43 ` Thomas Gleixner
2011-12-13 22:56 ` Andi Kleen
2011-12-13 23:08 ` Steven Rostedt
2011-12-13 23:15 ` Mathieu Desnoyers
2011-12-13 23:16 ` Steven Rostedt
2011-12-13 23:17 ` Thomas Gleixner
2011-12-13 22:22 ` Cyrill Gorcunov [this message]
2011-12-13 22:27 ` [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files v2 Andi Kleen
2011-12-13 23:03 ` Thomas Gleixner
2011-12-13 23:11 ` Andi Kleen
2011-12-13 23:16 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2011-12-02 20:02 Andi Kleen
2011-12-12 22:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213222256.GD2618@moon \
--to=gorcunov@gmail.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.