From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sandbox: Add tap based networking
Date: Tue, 13 Dec 2011 22:35:24 -0500 [thread overview]
Message-ID: <201112132235.25518.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ2KYfVHmr2UTgBGVdWKVQpODuz9epZ_pn1Kgbb5udia6g@mail.gmail.com>
On Tuesday 13 December 2011 18:54:59 Simon Glass wrote:
> On Sun, Dec 4, 2011 at 9:57 AM, Matthias Weisser wrote:
> > --- a/arch/sandbox/cpu/os.c
> > +++ b/arch/sandbox/cpu/os.c
> > @@ -19,6 +19,7 @@
> > * MA 02111-1307 USA
> > */
> >
> > +#include <config.h>
> > #include <fcntl.h>
> > #include <stdlib.h>
> > #include <termios.h>
> > @@ -30,6 +31,19 @@
> > #include <sys/mman.h>
> > #include <linux/types.h>
> >
> > +#ifdef CONFIG_NET_TAP
>
> I don't think we need this #ifdef
i think it's fine. the current code isn't too tied to Linux, but adding
NET_TAP unconditionally would make it completely Linux specific ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111213/3e952547/attachment.pgp>
next prev parent reply other threads:[~2011-12-14 3:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 14:09 [U-Boot] [PATCH RFC] sandbox: Add tap based networking Matthias Weisser
2011-11-29 15:24 ` Mike Frysinger
2011-11-29 18:21 ` Matthias Weisser
2011-11-29 18:39 ` Mike Frysinger
2011-12-03 15:06 ` Matthias Weisser
2011-12-03 17:02 ` Mike Frysinger
2011-12-04 17:57 ` [U-Boot] [PATCH] " Matthias Weisser
2011-12-13 23:54 ` Simon Glass
2011-12-14 3:35 ` Mike Frysinger [this message]
2011-12-15 15:46 ` Simon Glass
2011-12-17 22:47 ` Wolfgang Denk
2012-01-08 8:47 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112132235.25518.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.