From: Greg KH <greg@kroah.com>
To: Ajeet Yadav <ajeet.yadav.77@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Jerome Marchand <jmarchan@redhat.com>,
Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: zram: print the disk size in KB
Date: Tue, 13 Dec 2011 16:18:47 -0800 [thread overview]
Message-ID: <20111214001847.GA26688@kroah.com> (raw)
In-Reply-To: <CAB4K4y74HtRxF6iMayonaSvc2Uoe9Fr+7Bwf9Fr05NwbrSDU8g@mail.gmail.com>
On Tue, Dec 13, 2011 at 10:46:53AM +0530, Ajeet Yadav wrote:
> >From a5d5ba92b5af9134e617986884856334c377e1d0 Mon Sep 17 00:00:00 2001
> From: Ajeet Yadav <ajeet.yadav.77@gmail.com>
> Date: Mon, 12 Dec 2011 18:42:30 +0530
> Subject: [PATCH 1/1] Staging: zram: print the disk size in KB
Why did you include the patch in an email instead of using
git-send-email? This would force me to edit the patch by hand, removing
this useless stuff.
>
> Total memory size is in KB, but the zram disk size was not
> printed in KB, correct the figure in KB units.
>
> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
> ---
> drivers/staging/zram/zram_drv.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> index 09de99f..ff591e3 100644
> --- a/drivers/staging/zram/zram_drv.c
> +++ b/drivers/staging/zram/zram_drv.c
> @@ -126,7 +126,7 @@ static void zram_set_disksize(struct zram *zram,
> size_t totalram_bytes)
And your patch is line-wrapped, making it so I would have to edit it
again.
Please fix up, and get the acks from the zram maintainer (as this does
change a kernel/user api) before I can accept this.
greg k-h
next prev parent reply other threads:[~2011-12-14 0:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 5:16 [PATCH 1/1] Staging: zram: print the disk size in KB Ajeet Yadav
2011-12-14 0:18 ` Greg KH [this message]
2011-12-14 6:00 ` Ajeet Yadav
2011-12-14 1:50 ` Nitin Gupta
2011-12-14 7:52 ` Geert Uytterhoeven
2011-12-14 10:16 ` Jerome Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214001847.GA26688@kroah.com \
--to=greg@kroah.com \
--cc=ajeet.yadav.77@gmail.com \
--cc=gregkh@suse.de \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.