From: Olaf Hering <olaf@aepfle.de>
To: Roger Pau Monne <roger.pau@entel.upc.edu>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] xenpaging: remove XOPEN_SOURCE
Date: Wed, 14 Dec 2011 14:37:45 +0100 [thread overview]
Message-ID: <20111214133745.GA20665@aepfle.de> (raw)
In-Reply-To: <7697ee23b08b8eaca9ae.1323768649@loki.upc.es>
On Tue, Dec 13, Roger Pau Monne wrote:
> # HG changeset patch
> # User Roger Pau Monne <roger.pau@entel.upc.edu>
> # Date 1323768129 -3600
> # Node ID 7697ee23b08b8eaca9aee4f6b79cf550a490bef7
> # Parent 8a84f53376862427f254a017cb52c928dbdd3d32
> xenpaging: remove XOPEN_SOURCE
>
> The XOPEN_SOURCE define was breaking the compilation under NetBSD.
> I've removed it becasue it is not necessary (at least under NetBSD).
> If it is necessary for Linux, we can add a ifdef conditional to remove
> this only under NetBSD.
Please resend with the exact error message in NetBSD.
24223:9e3c2ef70c8a should have removed _XOPEN_SOURCE, and
22023:af6799abc6e9 should have added _GNU_SOURCE in the first place
(and give the exact error message as well).
Other than that:
Acked-by: Olaf Hering <olaf@aepfle.de>
prev parent reply other threads:[~2011-12-14 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 9:30 [PATCH] xenpaging: remove XOPEN_SOURCE Roger Pau Monne
2011-12-13 10:02 ` Ian Campbell
2011-12-13 10:39 ` Laszlo Ersek
2011-12-13 13:21 ` Roger Pau Monné
2011-12-13 14:53 ` Ian Jackson
2011-12-14 10:14 ` Roger Pau Monné
2011-12-14 10:23 ` Olaf Hering
2011-12-14 11:02 ` Roger Pau Monné
2011-12-14 13:37 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214133745.GA20665@aepfle.de \
--to=olaf@aepfle.de \
--cc=roger.pau@entel.upc.edu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.