All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 1/5] Add support for getting the Encryption Key Size via btio
Date: Wed, 14 Dec 2011 13:35:57 -0300	[thread overview]
Message-ID: <20111214163557.GA17841@samus> (raw)
In-Reply-To: <CABBYNZJzb6nSbq6JpKOn3HxcaYvLSw0JWzzHQsYh+DtfFfb+7w@mail.gmail.com>

Hi Luiz,

On 14:09 Wed 14 Dec, Luiz Augusto von Dentz wrote:
> Hi Vinicius,
> 
> On Wed, Dec 14, 2011 at 1:57 AM, Vinicius Costa Gomes
> <vinicius.gomes@openbossa.org> wrote:
> > +static gboolean get_key_size(int sock, BtIOType type, int *size,
> > +                                                               GError **err)
> > +{
> > +       struct bt_security sec;
> > +       socklen_t len;
> > +
> > +       memset(&sec, 0, sizeof(sec));
> > +       len = sizeof(sec);
> > +       if (getsockopt(sock, SOL_BLUETOOTH, BT_SECURITY, &sec, &len) == 0) {
> > +               *size = sec.key_size;
> > +               return TRUE;
> > +       }
> > +
> > +       return FALSE;
> > +}
> 
> It doesn't seems that the type is used for anything here, so you can
> probably removed it.

True. I will fix it.

> 
> -- 
> Luiz Augusto von Dentz


Cheers,
-- 
Vinicius

  reply	other threads:[~2011-12-14 16:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 23:57 [PATCH BlueZ 1/5] Add support for getting the Encryption Key Size via btio Vinicius Costa Gomes
2011-12-13 23:57 ` [PATCH BlueZ 2/5] Add support for passing the CID to btiotest Vinicius Costa Gomes
2011-12-13 23:57 ` [PATCH BlueZ 3/5] Add support for btiotest to returning the key size Vinicius Costa Gomes
2011-12-13 23:57 ` [PATCH BlueZ 4/5] Remove the default security level from btio Vinicius Costa Gomes
2011-12-14 11:43   ` Ganir, Chen
2011-12-14 13:56     ` Vinicius Gomes
2011-12-13 23:57 ` [PATCH BlueZ 5/5] Fix btio users to not expect a default security level Vinicius Costa Gomes
2011-12-14 12:09 ` [PATCH BlueZ 1/5] Add support for getting the Encryption Key Size via btio Luiz Augusto von Dentz
2011-12-14 16:35   ` Vinicius Costa Gomes [this message]
2011-12-14 17:02 ` Vinicius Costa Gomes
2011-12-15 11:37 ` Johan Hedberg
2011-12-15 19:18   ` Vinicius Costa Gomes
2012-01-22 20:29     ` Anderson Lizardo
2012-01-23 11:15       ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111214163557.GA17841@samus \
    --to=vinicius.gomes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.