From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/5] ARM: SMP: Refactor Kconfig to be more maintainable
Date: Wed, 14 Dec 2011 18:20:04 +0000 [thread overview]
Message-ID: <20111214182004.GA9331@linaro.org> (raw)
In-Reply-To: <20111214174618.GB22025@huya.qualcomm.com>
On Wed, Dec 14, 2011 at 09:46:18AM -0800, David Brown wrote:
> On Wed, Dec 14, 2011 at 11:36:55AM +0000, Dave Martin wrote:
> > On Tue, Dec 13, 2011 at 12:11:37PM -0800, David Brown wrote:
> > > On Tue, Dec 13, 2011 at 05:56:30PM +0000, Dave Martin wrote:
> > > > Making SMP depend on (huge list of MACH_ and ARCH_ configs) is
> > > > bothersome to maintain and likely to lead to merge conflicts.
> > >
> > > > diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig
> > > > index ebde97f..e6beaff 100644
> > > > --- a/arch/arm/mach-msm/Kconfig
> > > > +++ b/arch/arm/mach-msm/Kconfig
> > > > @@ -67,6 +67,7 @@ config MSM_SOC_REV_A
> > > > bool
> > > > config ARCH_MSM_SCORPIONMP
> > > > bool
> > > > + select HAVE_SMP
> > > >
> > > > config ARCH_MSM_ARM11
> > > > bool
> > >
> > > The ARCH_MSM_SCORPIONMP config's only purpose was to enable SMP higher
> > > up. We might as well eliminate ARCH_MSM_SCORPIONMP entirely, and just
> > > select HAVE_SMP in ARCH_MSM8X60 and ARCH_MSM8960.
> >
> > First and foremost, I'm just refactoring with this series. I've
> > included other trivial changes suggested by other people where the
> > effect is clear and straightforward.
>
> In that light, your patch is probably the right approach. I can clean
> our stuff up and sent out other patches later.
OK, thanks for confirming.
Cheers
---Dave
next prev parent reply other threads:[~2011-12-14 18:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 17:56 [PATCH v4 0/5] Refactor common Kconfigs for easier maintenance Dave Martin
2011-12-13 17:56 ` [PATCH v4 1/5] ARM: l2x0/pl310: Refactor Kconfig to be more maintainable Dave Martin
2011-12-13 17:56 ` [PATCH v4 2/5] ARM: SMP: " Dave Martin
2011-12-13 20:11 ` David Brown
2011-12-14 11:36 ` Dave Martin
2011-12-14 17:46 ` David Brown
2011-12-14 18:20 ` Dave Martin [this message]
2011-12-14 17:31 ` Linus Walleij
2011-12-18 4:22 ` Olof Johansson
2011-12-13 17:56 ` [PATCH v4 3/5] omap4: Unconditionally require l2x0 L2 cache controller support Dave Martin
2011-12-13 17:56 ` [PATCH v4 4/5] highbank: " Dave Martin
2011-12-13 17:56 ` [PATCH v4 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214182004.GA9331@linaro.org \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.