From: "John W. Linville" <linville@tuxdriver.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2 1/2] cfg80211: Define a wrapper function for reporting roaming
Date: Wed, 14 Dec 2011 13:54:49 -0500 [thread overview]
Message-ID: <20111214185448.GB2607@tuxdriver.com> (raw)
In-Reply-To: <20111207150543.GA12498@chvasanth-lnx>
On Wed, Dec 07, 2011 at 08:35:45PM +0530, Vasanthakumar Thiagarajan wrote:
> On Wed, Dec 07, 2011 at 07:28:24PM +0530, Vasanthakumar Thiagarajan wrote:
> > >
> > > Hmm, now that I think about it more, I think the calling convention is
> > > really strange. Why pass the channel and bssid when the BSS struct is
> > > already known?
> > >
> > > Why not make cfg80211_roamed() do the BSS lookup (which would also
> > > reduce the race for drivers that don't use _bss()) based on the info,
> > > and then call a cfg80211_roamed_bss() that doesn't get channel/bssid.
> >
> > Sure, i'll change it. This looks better.
>
> Also, i'll create a new patch instead of the next version.
Is that patch still coming?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-12-14 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 13:42 [PATCH V2 1/2] cfg80211: Define a wrapper function for reporting roaming Vasanthakumar Thiagarajan
2011-12-07 13:46 ` Johannes Berg
2011-12-07 13:58 ` Vasanthakumar Thiagarajan
2011-12-07 15:05 ` Vasanthakumar Thiagarajan
2011-12-14 18:54 ` John W. Linville [this message]
2011-12-15 4:39 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214185448.GB2607@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.