From: Jamie Iles <jamie@jamieiles.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Jamie Iles <jamie@jamieiles.com>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH] irq: fix crash due to op-less irq domains
Date: Wed, 14 Dec 2011 22:22:33 +0000 [thread overview]
Message-ID: <20111214222232.GA3125@gallagher> (raw)
In-Reply-To: <4EE91FDD.5070206@gmail.com>
On Wed, Dec 14, 2011 at 04:14:53PM -0600, Rob Herring wrote:
> Linus,
>
> On 12/14/2011 02:55 PM, Linus Walleij wrote:
> > From: Linus Walleij <linus.walleij@linaro.org>
> >
> > IRQ domains without ops does not work anymore after commit
> > "irq: support domains with non-zero hwirq base", since the
> > check dereferences domain->ops->to_irq without checking of
> > domain->ops are NULL. This makes U300 (and probably most other
> > systems using the PL190 VIC) boot again.
>
> I thought the VIC series had the fix for this, but it seems not. NULL
> ops is considered invalid based on the code comments. The correct fix is
> this patch:
>
> irqdomain: export irq_domain_simple_ops for !CONFIG_OF
> http://www.spinics.net/lists/arm-kernel/msg150290.html
>
> I believe this is going in with some iMX changes. But I guess the VIC is
> going to need a fix to use irq_domain_simple_ops.
Yes, Thomas has acked that patch, but it wasn't clear who was going to
merge it. I asked if this could go through Russell along with a patch
to make the VIC driver use it but haven't heard anything back yet. I'll
repost them now.
Jamie
next prev parent reply other threads:[~2011-12-14 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 20:55 [PATCH] irq: fix crash due to op-less irq domains Linus Walleij
2011-12-14 22:14 ` Rob Herring
2011-12-14 22:22 ` Jamie Iles [this message]
2011-12-14 22:26 ` Linus Walleij
2011-12-14 22:24 ` Linus Walleij
2011-12-15 7:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214222232.GA3125@gallagher \
--to=jamie@jamieiles.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=robherring2@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.