From: Steve Grubb <sgrubb@redhat.com>
To: Stephen Quinney <squinney@inf.ed.ac.uk>
Cc: linux-audit@redhat.com
Subject: Re: test patch for auditctl inter-field comparisons on euid/uid, egid/gid
Date: Thu, 15 Dec 2011 08:36:02 -0500 [thread overview]
Message-ID: <201112150836.03010.sgrubb@redhat.com> (raw)
In-Reply-To: <20111215065553.GA27897@hogwood.inf.ed.ac.uk>
On Thursday, December 15, 2011 01:55:53 AM Stephen Quinney wrote:
> On Wed, Dec 14, 2011 at 05:18:30PM -0800, Peter Moody wrote:
> > diff --git a/trunk/auparse/typetab.h b/trunk/auparse/typetab.h
> > index 746573c..cf13f4d 100644
> > --- a/trunk/auparse/typetab.h
> > +++ b/trunk/auparse/typetab.h
> > @@ -32,6 +32,8 @@ _S(AUPARSE_TYPE_UID, "iuid" )
> >
> > _S(AUPARSE_TYPE_UID, "id" )
> > _S(AUPARSE_TYPE_UID, "inode_uid" )
> > _S(AUPARSE_TYPE_UID, "sauid" )
> >
> > +_S(AUPARSE_TYPE_UID, "obj_uid" )
> > +_S(AUPARSE_TYPE_UID, "obj_gid" )
> >
> > _S(AUPARSE_TYPE_GID, "gid" )
> > _S(AUPARSE_TYPE_GID, "egid" )
> > _S(AUPARSE_TYPE_GID, "sgid" )
>
> I don't know the code particularly well but from reading the patch it
> strikes me that in this chunk "obj_gid" should probably be
> AUPARSE_TYPE_GID rather than AUPARSE_TYPE_UID.
Yeah, good catch. I can fix this when I apply the patch to svn. No need to re-
send unless there is something else needing fixing as well.
-Steve
next prev parent reply other threads:[~2011-12-15 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 19:09 test patch for auditctl inter-field comparisons on euid/uid, egid/gid Peter Moody
2011-12-12 14:40 ` Steve Grubb
2011-12-12 16:40 ` Peter Moody
2011-12-14 1:38 ` Peter Moody
2011-12-15 0:16 ` Peter Moody
2011-12-15 1:18 ` Peter Moody
2011-12-15 6:55 ` Stephen Quinney
2011-12-15 13:36 ` Steve Grubb [this message]
2011-12-16 23:34 ` Peter Moody
2012-02-28 23:07 ` Steve Grubb
2012-02-28 23:12 ` Peter Moody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112150836.03010.sgrubb@redhat.com \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=squinney@inf.ed.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.