All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bartosz Szatkowski <bulislaw@linux.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 4/4] Add support for PullMessagesListing in MAP client
Date: Thu, 15 Dec 2011 14:17:00 +0200	[thread overview]
Message-ID: <20111215121700.GA10535@x220> (raw)
In-Reply-To: <CAPGrrxWWRPkCyKgRu2SkEmdhjdZgkjEQ+ES0DhfuoshvsVBUfw@mail.gmail.com>

Hi Bartosz,

On Thu, Dec 15, 2011, Bartosz Szatkowski wrote:
> > The name should be GetMessageListing and not GetMessagesListing (the
> > latter isn't really proper english). I went ahead and changed it through
> > a separate patch since I didn't notice before having already applied
> > your patch. Also, all this seems to be missing from the API
> > documentation (doc/*). Please send a patch for that.
> 
> The function name is "GetMessagesListing" in spec.
> There is no doc as at the moment there is no apparams handling and no
> xml parsing, so I'll send patch with doc when we reach full
> functionality.

So the plan is to return something else than the raw XML that MAP
provides? In that case I don't think it's necessary to hold on to the
exact spec naming of these functions. E.g. GetMessages or GetMessageList
might make more sense in the case that you return a pre-parsed
list/structure of some kind.

Johan

  reply	other threads:[~2011-12-15 12:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 15:31 [PATCH obexd 1/4] Add support for SetFolder in MAP client Bartosz Szatkowski
2011-12-12 15:31 ` [PATCH obexd 2/4] Add simple helper for " Bartosz Szatkowski
2011-12-12 15:31 ` [PATCH obexd 3/4] Add basic support for MAP folder listing Bartosz Szatkowski
2011-12-12 15:31 ` [PATCH obexd 4/4] Add support for PullMessagesListing in MAP client Bartosz Szatkowski
2011-12-15 11:50   ` Johan Hedberg
2011-12-15 11:54     ` Johan Hedberg
2011-12-15 11:56       ` Bartosz Szatkowski
2011-12-15 12:10         ` Johan Hedberg
2011-12-15 12:13           ` Johan Hedberg
2011-12-15 11:54     ` Bartosz Szatkowski
2011-12-15 12:17       ` Johan Hedberg [this message]
2011-12-15 12:45         ` Bartosz Szatkowski
2012-06-06  8:14           ` Luiz Augusto von Dentz
2012-06-06  9:19             ` Bartosz Szatkowski
2011-12-15 11:43 ` [PATCH obexd 1/4] Add support for SetFolder " Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111215121700.GA10535@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=bulislaw@linux.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.