From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Roger Pau Monne <roger.pau@entel.upc.edu>, xen-devel@lists.xensource.com
Subject: Re: [PATCH v2] xenpaging: remove _XOPEN_SOURCE
Date: Thu, 15 Dec 2011 19:51:24 +0100 [thread overview]
Message-ID: <20111215185124.GA30948@aepfle.de> (raw)
In-Reply-To: <20202.11863.501987.497546@mariner.uk.xensource.com>
On Thu, Dec 15, Ian Jackson wrote:
> Roger Pau Monne writes ("[Xen-devel] [PATCH v2] xenpaging: remove _XOPEN_SOURCE"):
> > xenpaging: remove _XOPEN_SOURCE
> >
> > The _XOPEN_SOURCE define was breaking the compilation under NetBSD.
> > I've removed it becasue it is not necessary.
>
> I thought we'd decided that _NETBSD_SOURCE should be added ?
The initial patch which added _XOPEN_SOURCE should have a reasonable
description which includes the error message, and it should have been
_GNU_SOURCE instead of _XOPEN_SOURCE in the first place.
Please remove _XOPEN_SOURCE.
Olaf
next prev parent reply other threads:[~2011-12-15 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 14:08 [PATCH v2] xenpaging: remove _XOPEN_SOURCE Roger Pau Monne
2011-12-15 17:28 ` Ian Jackson
2011-12-15 17:34 ` Roger Pau Monné
2011-12-15 17:36 ` Ian Jackson
2011-12-15 17:40 ` Roger Pau Monné
2011-12-15 17:41 ` Ian Jackson
2011-12-15 18:51 ` Olaf Hering [this message]
2011-12-16 8:50 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215185124.GA30948@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=roger.pau@entel.upc.edu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.