All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org
Subject: [RFC PATCH] scsi_dh: allow 3rd party multipath drivers to scsi_dh_detach
Date: Thu, 15 Dec 2011 16:44:40 -0500	[thread overview]
Message-ID: <20111215214440.GA17677@redhat.com> (raw)

Some scsi_dh modules are known to conflict with with 3rd party multipath
drivers (e.g. scsi_dh_emc conflicts with EMC PowerPath).

Allow 3rd party multipath drivers to programatically detach a scsi_dh
using the scsi_dh_detach() interface rather than require writing
'detach' to /sys/block/sdX/queue/dh_state

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
 drivers/scsi/device_handler/scsi_dh.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[begs the question: why are _any_ of the scsi_dh symbols
EXPORT_SYMBOL_GPL?  Linux would benefit from more 3rd party use of
scsi_dh*.  As it stands, Linux is being held back from having better
default handling of multipath LUNs purely because 3rd parties may not
play nicely with scsi_dh* being attached]

diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c
index 23149b9..a550de1 100644
--- a/drivers/scsi/device_handler/scsi_dh.c
+++ b/drivers/scsi/device_handler/scsi_dh.c
@@ -578,7 +578,7 @@ void scsi_dh_detach(struct request_queue *q)
 	}
 	put_device(&sdev->sdev_gendev);
 }
-EXPORT_SYMBOL_GPL(scsi_dh_detach);
+EXPORT_SYMBOL(scsi_dh_detach);
 
 static struct notifier_block scsi_dh_nb = {
 	.notifier_call = scsi_dh_notifier

             reply	other threads:[~2011-12-15 21:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 21:44 Mike Snitzer [this message]
2011-12-20  7:31 ` [RFC PATCH] scsi_dh: allow 3rd party multipath drivers to scsi_dh_detach Hannes Reinecke
2012-01-05 15:24   ` Mike Snitzer
2012-04-05 14:47   ` Mike Snitzer
2012-04-20 14:45     ` [RESEND][PATCH] [SCSI] scsi_dh: allow 3rd party multipath drivers to use scsi_dh_detach Mike Snitzer
2012-04-20 15:17       ` James Bottomley
2012-04-20 15:46         ` Mike Snitzer
2012-04-20 15:49         ` Chandra Seetharaman
2012-04-20 17:34       ` [PATCH v2] [SCSI] scsi_dh: change scsi_dh_detach export to EXPORT_SYMBOL Mike Snitzer
2012-04-20 20:41         ` Alan Cox
2012-04-20 21:58           ` Mike Snitzer
2012-04-20 22:20             ` Alan Cox
2012-04-20 22:58               ` Mike Snitzer
2012-04-20 23:14                 ` Alan Cox
2012-04-20 23:34                   ` Mike Snitzer
2012-04-22 22:13                   ` Mike Snitzer
2012-04-22 22:34                     ` Alan Cox
2012-04-22 23:01                       ` Mike Snitzer
2012-04-22 23:13                         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111215214440.GA17677@redhat.com \
    --to=snitzer@redhat.com \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.