All of lore.kernel.org
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix $(CROSS_COMPILE) prefix missing from size invocation
Date: Thu, 15 Dec 2011 14:14:06 -0800	[thread overview]
Message-ID: <20111215221406.GY32251@atomide.com> (raw)
In-Reply-To: <201112150228.34815.jkrzyszt@tis.icnet.pl>

* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [111214 16:59]:
> On Wednesday 14 of December 2011 at 22:58:15, Tony Lindgren wrote:
> > * Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [111213 14:55]:
> > > On Friday 25 of November 2011 at 02:58:58, Janusz Krzysztofik wrote:
> > > > Otherwise, cross compilation may fail with error messages like:
> > > > 
> > > > ...
> > > > size: arch/arm/boot/compressed/../../../../vmlinux: File format is ambiguous
> > > > size: Matching formats: elf32-littlearm elf32-littlearm-symbian elf32-littlearm-vxworks
> > > >   LD      arch/arm/boot/compressed/vmlinux
> > > >   arm-angstrom-linux-uclibcgnueabi-ld:--defsym _kernel_bss_size=: syntax error
> > > > 
> > > > Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> > > 
> > > Trying to guess why this patch is still sitting in the Incoming queue in 
> > > the Russell's patch system (7184/1) while others have found their way to 
> > > the Applied queue meanwhile, I wonder if this is because I didn't 
> > > mention explicitly that it is a fix to a regression introduced into 
> > > 3.2-rc with the following commit:
> > 
> > It's because not all cross compiler in use have $(CROSS_COMPILE)size
> > available, so it would have to be symlinked to host size to keep things
> > compiling. So it's probably best to rather take the warning and keep
> > things compiling rather than fix the warning and break compile for
> > many people.
> 
> First of all, thanks for someone finally commenting the patch. It's really hard for me to guess if a patch is OK or not if I hear nothing. Once I hear from someone what is wrong with my patch, I'm always willing to enhance it. But I feel more and more like an intruder on the linux-arm-kernel list.

I thought this was already discussed a while back on the LAKML list?
 
> Back to the merit: I would take that warning, as you suggest, if things were compiling for me, but it's not the case. Compilation fails, as I tried to state in the commit message. The patch was not about fixing the warning, but fixing the compilation broken. Since things worked for me before, I find it a regression. Sorry if I was not clear enough in the commit message.
> 
> I'll prepare v2 which will call $(CROSS_COMPILE)size if size fails, OK?

Sounds good :)

Tony

  reply	other threads:[~2011-12-15 22:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-25  1:58 [PATCH] ARM: fix $(CROSS_COMPILE) prefix missing from size invocation Janusz Krzysztofik
2011-12-13 23:21 ` Janusz Krzysztofik
2011-12-14 21:58   ` Tony Lindgren
2011-12-15  1:28     ` Janusz Krzysztofik
2011-12-15 22:14       ` Tony Lindgren [this message]
     [not found] <Message-ID: <20111214215815.GP32251@atomide.com>
2011-12-16 10:42 ` [PATCH] ARM: Fix cross compilation broken by failing size command Janusz Krzysztofik
2011-12-16 10:42   ` Janusz Krzysztofik
2011-12-17  0:30   ` Tony Lindgren
2011-12-17  0:30     ` Tony Lindgren
2011-12-17 10:57   ` Russell King - ARM Linux
2011-12-17 10:57     ` Russell King - ARM Linux
2011-12-17 13:01     ` Janusz Krzysztofik
2011-12-17 13:01       ` Janusz Krzysztofik
2011-12-17 16:38       ` Nicolas Pitre
2011-12-17 16:38         ` Nicolas Pitre
2011-12-17 17:15         ` Russell King - ARM Linux
2011-12-17 17:15           ` Russell King - ARM Linux
2011-12-17 18:57         ` Janusz Krzysztofik
2011-12-17 18:57           ` Janusz Krzysztofik
2011-12-19  8:27   ` Igor Grinberg
2011-12-19  8:27     ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111215221406.GY32251@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.