From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
kgiori@qca.qualcomm.com, zefir.kurtisi@neratec.com
Subject: Re: [PATCH 3/3] ath9k: add DFS radar pulse processing
Date: Thu, 15 Dec 2011 18:06:20 -0800 [thread overview]
Message-ID: <20111216000804.GA1092@tux> (raw)
In-Reply-To: <CAGRGNgXPFM4Yo4WM0mUp0=famt2JeLxSRAX=iVtYDiGo9r+RTw@mail.gmail.com>
On Thu, Dec 15, 2011 at 03:58:32PM +1100, Julian Calaby wrote:
> > diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile
> > index 390797d..783559c 100644
> > --- a/drivers/net/wireless/ath/ath9k/Makefile
> > +++ b/drivers/net/wireless/ath/ath9k/Makefile
> > @@ -10,6 +10,8 @@ ath9k-$(CONFIG_ATH9K_RATE_CONTROL) += rc.o
> > ath9k-$(CONFIG_ATH9K_PCI) += pci.o
> > ath9k-$(CONFIG_ATH9K_AHB) += ahb.o
> > ath9k-$(CONFIG_ATH9K_DEBUGFS) += debug.o
> > +ath9k-$(CONFIG_ATH9K_DEBUGFS) += dfs_debug.o
>
> Shouldn't this config variable be CONFIG_ATH9K_DFS_DEBUGFS?
Yeap!
> You introduce that config variable but never use it.
Good catch.
> > +ath9k-$(CONFIG_ATH9K_DFS_CERTIFIED) += dfs.o
> >
> > obj-$(CONFIG_ATH9K) += ath9k.o
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/dfs_debug.h b/drivers/net/wireless/ath/ath9k/dfs_debug.h
> > <etC>
> > +
> > +#if defined(CONFIG_ATH9K_DEBUGFS)
>
> Same here.
>
> > +
> > +#define DFS_STAT_INC(sc, c) (sc->debug.stats.dfs_stats.c++)
> > +void ath9k_dfs_init_debug(struct ath_softc *sc);
> > +
> > +#else
> > +
> > +#define DFS_STAT_INC(sc, c) do { } while (0)
> > +static inline void ath9k_dfs_init_debug(struct ath_softc *sc) { }
> > +
> > +#endif /* CONFIG_ATH9K_DEBUGFS */
>
> And here =)
Thanks for the review, I just submitted a v2.
Luis
next prev parent reply other threads:[~2011-12-16 2:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 4:16 [PATCH 0/3] ath9k: DFS placeholders Luis R. Rodriguez
2011-12-15 4:16 ` [PATCH 1/3] ath: add a debug level for DFS Luis R. Rodriguez
2011-12-15 4:16 ` [PATCH 2/3] ath9k_hw: add DFS testing check Luis R. Rodriguez
2011-12-15 4:16 ` [PATCH 3/3] ath9k: add DFS radar pulse processing Luis R. Rodriguez
2011-12-15 4:58 ` Julian Calaby
2011-12-16 2:06 ` Luis R. Rodriguez [this message]
2011-12-15 4:16 ` [DO NOT APPLY] ath9k: DFS poo Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216000804.GA1092@tux \
--to=mcgrof@gmail.com \
--cc=julian.calaby@gmail.com \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.