From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: Seth Forshee <seth.forshee@canonical.com>,
Len Brown <lenb@kernel.org>,
Azael Avalos <coproscefalo@gmail.com>,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Subject: Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()
Date: Fri, 16 Dec 2011 00:33:33 +0000 [thread overview]
Message-ID: <20111216003333.GA18489@srcf.ucam.org> (raw)
In-Reply-To: <201112160122.36100.trenn@suse.de>
On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote:
> I think best is to move the thinkpad implementation of getting
> ACPI handles based on HIDs to osl.c and make it global.
> I'll send patches.
> Please review them carefully, they are only compile tested.
The ec driver is already finding the hardware on the basis of the HID -
is there any reason to do this twice rather than just exporting the
information the ec driver already has?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-12-16 0:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 18:06 [PATCH 0/4] toshiba_acpi: Expanded hotkey support Seth Forshee
2011-12-15 18:06 ` [PATCH 1/4] ACPI: EC: Add ec_get_handle() Seth Forshee
2011-12-16 0:22 ` Thomas Renninger
2011-12-16 0:33 ` Matthew Garrett [this message]
2011-12-16 1:52 ` Thomas Renninger
2011-12-16 13:19 ` Thomas Renninger
2011-12-16 13:44 ` Corentin Chary
2011-12-16 13:44 ` Corentin Chary
2011-12-16 14:18 ` Seth Forshee
2011-12-15 18:06 ` [PATCH 2/4] toshiba_acpi: Support alternate hotkey interfaces Seth Forshee
2011-12-17 8:31 ` Thomas Renninger
2011-12-17 11:32 ` Azael Avalos
2011-12-17 11:32 ` Azael Avalos
2011-12-17 15:07 ` Seth Forshee
2011-12-17 15:07 ` Seth Forshee
2011-12-18 14:01 ` Thomas Renninger
2011-12-19 18:24 ` Seth Forshee
2011-12-15 18:06 ` [PATCH 3/4] toshiba_acpi: Support additional hotkey scancodes Seth Forshee
2011-12-15 18:06 ` [PATCH 4/4] toshiba_acpi: Add blacklist for devices with hotkey problems Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216003333.GA18489@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=coproscefalo@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=seth.forshee@canonical.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.