All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "frank.rowand@am.sony.com" <frank.rowand@am.sony.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>
Subject: Re: [PATCH] PREEMPT_RT_FULL: ARM context switch needs IRQs enabled
Date: Fri, 16 Dec 2011 11:13:19 +0000	[thread overview]
Message-ID: <20111216111319.GB6342@arm.com> (raw)
In-Reply-To: <1324029272.18942.73.camel@twins>

On Fri, Dec 16, 2011 at 09:54:32AM +0000, Peter Zijlstra wrote:
> On Thu, 2011-12-15 at 19:20 -0800, Frank Rowand wrote:
> > ARMv6 and later have VIPT caches and the TLBs are tagged with an ASID
> > (application specific ID). The number of ASIDs is limited to 256 and
> > the allocation algorithm requires IPIs when all the ASIDs have been
> > used.  The IPIs require interrupts enabled during context switch for
> > deadlock avoidance.
> > 
> > The RT patch mm-protect-activate-switch-mm.patch disables irqs around
> > activate_mm() and switch_mm(), which are the portion of the ARMv6
> > context switch that require interrupts enabled.
> > 
> > The solution for the ARMv6 processors could be to _not_ disable irqs.
> > A more conservative solution is to provide the same environment that
> > the scheduler provides, that is preempt_disable().  This is more
> > resilient for possible future changes to the ARM context switch code
> > that is not aware of the RT patches.
> > 
> > This patch will conflict slightly with Catalin's patch set to remove
> > __ARCH_WANT_INTERRUPTS_ON_CTXSW, when that is accepted:
> > 
> >    http://lkml.indiana.edu/hypermail/linux/kernel/1111.3/01893.html
> > 
> > When Catalin's patch set is accepted, this RT patch will need to reverse
> > the change in patch 6 to arch/arm/include/asm/system.h:
> 
> 
> We could just merge Catalin's stuff in -rt to give it a test ride and
> see if anything horrible happens.. :-)

Russell agreed for me to push this to -next (in case -rt uses that, not
sure) to get a bit more exposure. Otherwise testing the patches in -rt
would really help spotting bugs.

But we need to sort out the dangling switch_mm() calls (without a
corresponding post-switch hook call) that I mentioned in my reply to
Frank.

-- 
Catalin

  reply	other threads:[~2011-12-16 11:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-16  3:20 [PATCH] PREEMPT_RT_FULL: ARM context switch needs IRQs enabled Frank Rowand
2011-12-16  9:54 ` Peter Zijlstra
2011-12-16 11:13   ` Catalin Marinas [this message]
2011-12-16 11:43     ` Catalin Marinas
2011-12-16 12:49       ` Peter Zijlstra
2011-12-16 15:23         ` Catalin Marinas
2011-12-16 21:43   ` Steven Rostedt
2011-12-16 11:01 ` Catalin Marinas
2011-12-16 23:23   ` Frank Rowand
2011-12-19 10:02     ` Catalin Marinas
2011-12-20  1:49       ` Frank Rowand
2011-12-20 12:25         ` Catalin Marinas
     [not found]         ` <CAHkRjk5AbCGzPtb5qeWL4CpK=KrBzL_QgD55tzS36dGRjn-rQA@mail.gmail.com>
2011-12-20 20:09           ` Frank Rowand
2011-12-16 20:56 ` Frank Rowand
2011-12-16 21:36   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111216111319.GB6342@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=frank.rowand@am.sony.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.