All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Michael Williamson <michael.williamson@criticallink.com>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [RFC PATCH 1/1] ASoC: dsd1791: Introduce driver for TI DSD1791 stereo codec
Date: Fri, 16 Dec 2011 13:53:21 +0100	[thread overview]
Message-ID: <20111216125320.GA2710@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4EEA5956.1090208@criticallink.com>

On Thu, Dec 15, 2011 at 03:32:22PM -0500, Michael Williamson wrote:
> On 12/15/2011 2:16 AM, Mark Brown wrote:
> > On Wed, Dec 14, 2011 at 06:40:43PM -0500, Michael Williamson wrote:

> >> +static int dsd1791_set_sysclk(struct snd_soc_dai *codec_dai,
> >> +				int clk_id, unsigned int freq, int dir)

> > Implement this as a CODEC wide operation, it's simpler.

> Not sure I follow you here.  Are you meaning to create something to
> replace these lines (which are in many of the routines) with a local inline?

No, I mean implement your set_sysclk operation as a CODEC wide
operation.

  reply	other threads:[~2011-12-16 12:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 23:40 [RFC PATCH 0/1] ASoC: dsd1791: Introduce driver for TI DSD1791 stereo codec Michael Williamson
2011-12-14 23:40 ` [RFC PATCH 1/1] " Michael Williamson
2011-12-15  6:58   ` Leon Romanovsky
2011-12-15  7:16   ` Mark Brown
2011-12-15 20:32     ` Michael Williamson
2011-12-16 12:53       ` Mark Brown [this message]
2011-12-15  8:57   ` Lars-Peter Clausen
2011-12-15  7:08 ` [RFC PATCH 0/1] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111216125320.GA2710@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@ti.com \
    --cc=michael.williamson@criticallink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.