From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bartosz Szatkowski <bulislaw@linux.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd 3/3] map: Add basic GetMessage support
Date: Fri, 16 Dec 2011 16:23:26 +0200 [thread overview]
Message-ID: <20111216142326.GA6469@x220> (raw)
In-Reply-To: <1324041790-17559-3-git-send-email-bulislaw@linux.com>
Hi Bartosz,
On Fri, Dec 16, 2011, Bartosz Szatkowski wrote:
> static GDBusMethodTable map_methods[] = {
> { "SetFolder", "s", "", map_setpath,
> G_DBUS_METHOD_FLAG_ASYNC },
> @@ -188,6 +232,7 @@ static GDBusMethodTable map_methods[] = {
> G_DBUS_METHOD_FLAG_ASYNC },
> { "GetMessageListing", "sa{ss}", "s", map_get_message_listing,
> G_DBUS_METHOD_FLAG_ASYNC },
> + { "GetMessage", "sa{ss}s", "o", map_get_message },
Before adding new methods could you please send a patch to add them to
the Message Access section in doc/client-api.txt. It should contain all
entries in this map_methods table but right now only contains SetFolder.
This will also help me understand the API, and particularly parameters
like "sa{ss}s" faster than by reading the code.
Johan
prev parent reply other threads:[~2011-12-16 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 13:23 [PATCH obexd 1/3] client: Fix opening file in obc_transfer_get Bartosz Szatkowski
2011-12-16 13:23 ` [PATCH obexd 2/3] client: Add file flexibility for GET Bartosz Szatkowski
2011-12-16 13:23 ` [PATCH obexd 3/3] map: Add basic GetMessage support Bartosz Szatkowski
2011-12-16 14:23 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216142326.GA6469@x220 \
--to=johan.hedberg@gmail.com \
--cc=bulislaw@linux.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.