All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH 1/1] udevd: process events with timeliness requirements
Date: Fri, 16 Dec 2011 17:53:25 +0000	[thread overview]
Message-ID: <20111216175325.GA5341@kroah.com> (raw)
In-Reply-To: <1324056944-4777-1-git-send-email-apw@canonical.com>

On Fri, Dec 16, 2011 at 05:35:44PM +0000, Andy Whitcroft wrote:
> diff --git a/udev/udevd.c b/udev/udevd.c
> index 05d4b2d..19f7128 100644
> --- a/udev/udevd.c
> 	+++ b/udev/udevd.c
> @@ -584,7 +584,7 @@ static void event_queue_start(struct udev *udev)
> 	}
> }
> 
> 	-static void event_queue_cleanup(struct udev *udev, enum event_state match_type)
> +static void __event_queue_cleanup(struct udev *udev, enum event_state match_type, bool keep_timely)
> {
> 	struct udev_list_node *loop, *tmp;
> 
> 	@@ -594,10 +594,25 @@ static void event_queue_cleanup(struct udev *udev, enum event_state match_type)
> 		if (match_type != EVENT_UNDEF && match_type != event->state)
> 			continue;
> 
> 	+		/* Keep events which have timelyness requirements
> 			   +		 * we will skew these timeouts on coldplug. */
> 		+		if (keep_timely && udev_device_get_timeout(event->dev) > 0)
> 		+			continue;
> 	+

Your patch is totally corrupted :(


      reply	other threads:[~2011-12-16 17:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-16 17:35 [PATCH 1/1] udevd: process events with timeliness requirements during exit to avoid deadlock Andy Whitcroft
2011-12-16 17:53 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111216175325.GA5341@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.