From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [GIT PULL] ARM: OMAP: I2C: prepare to use hwmod reset in driver Date: Fri, 16 Dec 2011 16:24:09 -0800 Message-ID: <20111217002409.GB6464@atomide.com> References: <20111216195002.GL32251@atomide.com> <20111216204123.GM32251@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:61234 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663Ab1LQAYL (ORCPT ); Fri, 16 Dec 2011 19:24:11 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: linux-omap@vger.kernel.org, Shubhrajyoti , b-cousson@ti.com, linux-arm-kernel@lists.infradead.org * Paul Walmsley [111216 12:27]: > Hi > > On Fri, 16 Dec 2011, Tony Lindgren wrote: > > > * Paul Walmsley [111216 11:45]: > > > On Fri, 16 Dec 2011, Tony Lindgren wrote: > > > > > > > * Paul Walmsley [111216 01:24]: > > > > > > > > > Shubhrajyoti D (2): > > > > > ARM: OMAP: omap_device: add omap_device_reset to reset all the hwmods in the device > > > > > ARM: OMAP: I2C: Reset support > > > > > > > > > Can you please update shi to leave out the extra callback > > > > function int (*device_reset) (struct device *dev) as I'd > > > > rather see that happen with pm_runtime calls? > > > > > > What PM runtime call is used to reset a device? > > > > Hmm how about pm_runtime_disable? Or do we need a new > > call for reset? Meanwhile as Paul pointed out, we still need the device_reset pointer, so pulling in this series into i2c branch. > Looking at the last few hunks of: > > http://marc.info/?l=linux-omap&m=132377389204328&w=2 > > it appears to me that the driver needs to reset the device while it's > still active & powered on, etc. > > Shubhrajyoti, care to comment further? > > > - Paul From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 16 Dec 2011 16:24:09 -0800 Subject: [GIT PULL] ARM: OMAP: I2C: prepare to use hwmod reset in driver In-Reply-To: References: <20111216195002.GL32251@atomide.com> <20111216204123.GM32251@atomide.com> Message-ID: <20111217002409.GB6464@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Paul Walmsley [111216 12:27]: > Hi > > On Fri, 16 Dec 2011, Tony Lindgren wrote: > > > * Paul Walmsley [111216 11:45]: > > > On Fri, 16 Dec 2011, Tony Lindgren wrote: > > > > > > > * Paul Walmsley [111216 01:24]: > > > > > > > > > Shubhrajyoti D (2): > > > > > ARM: OMAP: omap_device: add omap_device_reset to reset all the hwmods in the device > > > > > ARM: OMAP: I2C: Reset support > > > > > > > > > Can you please update shi to leave out the extra callback > > > > function int (*device_reset) (struct device *dev) as I'd > > > > rather see that happen with pm_runtime calls? > > > > > > What PM runtime call is used to reset a device? > > > > Hmm how about pm_runtime_disable? Or do we need a new > > call for reset? Meanwhile as Paul pointed out, we still need the device_reset pointer, so pulling in this series into i2c branch. > Looking at the last few hunks of: > > http://marc.info/?l=linux-omap&m=132377389204328&w=2 > > it appears to me that the driver needs to reset the device while it's > still active & powered on, etc. > > Shubhrajyoti, care to comment further? > > > - Paul