From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix and improve percpu_cmpxchg{8,16}b_double()
Date: Sun, 18 Dec 2011 09:43:51 +0100 [thread overview]
Message-ID: <20111218084351.GG4144@elte.hu> (raw)
In-Reply-To: <4EEB662A.9070308@zytor.com>
* H. Peter Anvin <hpa@zytor.com> wrote:
> On 12/14/2011 12:33 AM, Jan Beulich wrote:
> >
> > At once also change the return value type to what it really is -
> > 'bool'.
> >
>
> I have a hazy memory of "bool" not working correctly in inline assembly,
> but it might be ancient history by now.
I too have memory of badness - but i think it was something
about suboptimal code generated. We'll see any stability
problems soon enough, now that it's committed :-)
Thanks,
Ingo
prev parent reply other threads:[~2011-12-18 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 8:33 [PATCH] x86: fix and improve percpu_cmpxchg{8,16}b_double() Jan Beulich
2011-12-15 9:55 ` [tip:x86/asm] x86: Fix " tip-bot for Jan Beulich
2011-12-15 22:52 ` Christoph Lameter
2011-12-16 8:48 ` Jan Beulich
2011-12-16 15:39 ` [PATCH] x86: fix " H. Peter Anvin
2011-12-18 8:43 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111218084351.GG4144@elte.hu \
--to=mingo@elte.hu \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.