All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
	Asias He <asias.hejun@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	KVM-ML <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm tools: Use assert() helper to check a variable value
Date: Mon, 19 Dec 2011 11:57:38 +0400	[thread overview]
Message-ID: <20111219075738.GD17380@moon> (raw)
In-Reply-To: <alpine.LFD.2.02.1112190912260.2722@tux.localdomain>

On Mon, Dec 19, 2011 at 09:13:28AM +0200, Pekka Enberg wrote:
> >
> >-	BUILD_BUG_ON(i > E820_X_MAX);
> >+	assert(i <= E820_X_MAX);
> 
> We should use BUG_ON() like tools/perf does.
> 

We dont have it yet. So I'll introduce this helper later,
but note that we will have to cover _all_ assert() calls then,
so it's better to make in a separate patch. Meanwhile such fix
it better than bug ;)

	Cyrill

  reply	other threads:[~2011-12-19  7:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-18 21:35 [PATCH] kvm tools: Use assert() helper to check a variable value Cyrill Gorcunov
2011-12-19  7:13 ` Pekka Enberg
2011-12-19  7:57   ` Cyrill Gorcunov [this message]
2011-12-19  8:04     ` Ingo Molnar
2011-12-19  8:19     ` Pekka Enberg
2011-12-19  8:25       ` Cyrill Gorcunov
2011-12-19  8:48         ` Pekka Enberg
2011-12-19 10:40         ` Ingo Molnar
2011-12-19 10:49           ` Cyrill Gorcunov
2011-12-19 10:50             ` Ingo Molnar
2011-12-19 10:57               ` Pekka Enberg
2011-12-19 10:57               ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111219075738.GD17380@moon \
    --to=gorcunov@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.