From: Vivek Goyal <vgoyal@redhat.com>
To: Nate Custer <nate@cpanel.net>
Cc: Jens Axboe <axboe@kernel.dk>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH] blkio: alloc per cpu data from worker thread context( Re: kvm deadlock)
Date: Mon, 19 Dec 2011 08:40:12 -0500 [thread overview]
Message-ID: <20111219134012.GA7175@redhat.com> (raw)
In-Reply-To: <C1FB7932-7722-4160-8206-765B08EA5911@cpanel.net>
On Sun, Dec 18, 2011 at 03:25:48PM -0600, Nate Custer wrote:
>
> On Dec 16, 2011, at 2:29 PM, Vivek Goyal wrote:
> > Thanks for testing it Nate. I did some debugging and found out that patch
> > is doing double free on per cpu pointer hence the crash you are running
> > into. I could reproduce this problem on my box. It is just a matter of
> > doing rmdir on the blkio cgroup.
> >
> > I understood the cmpxchg() semantics wrong. I have fixed it now and
> > no crashes on directory removal. Can you please give this version a
> > try.
> >
> > Thanks
> > Vivek
>
> After 24 hours of stress testing the machine remains up and working without issue. I will continue to test it, but am reasonably confident that this patch resolves my issue.
That's good to know. While you continue to stress test, I will make some
minor modifications to the patch. (Thinking of delaying the retry of
allocation of per cpu memory in case previous attempts failed).
Thanks
Vivek
next prev parent reply other threads:[~2011-12-19 13:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 22:48 kvm deadlock Nate Custer
2011-12-14 12:25 ` Marcelo Tosatti
2011-12-14 13:43 ` Avi Kivity
2011-12-14 14:00 ` Marcelo Tosatti
2011-12-14 14:02 ` Avi Kivity
2011-12-14 14:06 ` Marcelo Tosatti
2011-12-14 14:17 ` Nate Custer
2011-12-14 14:20 ` Marcelo Tosatti
2011-12-14 14:28 ` Avi Kivity
2011-12-14 14:27 ` Avi Kivity
2011-12-14 16:03 ` Jens Axboe
2011-12-14 17:03 ` Vivek Goyal
2011-12-14 17:09 ` Jens Axboe
2011-12-14 17:22 ` Vivek Goyal
2011-12-14 18:16 ` Tejun Heo
2011-12-14 18:41 ` Vivek Goyal
2011-12-14 23:06 ` Vivek Goyal
2011-12-15 19:47 ` [RFT PATCH] blkio: alloc per cpu data from worker thread context( Re: kvm deadlock) Vivek Goyal
[not found] ` <E73DB38E-AFC5-445D-9E76-DE599B36A814@cpanel.net>
2011-12-16 20:29 ` Vivek Goyal
2011-12-18 21:25 ` Nate Custer
2011-12-19 13:40 ` Vivek Goyal [this message]
2011-12-19 17:27 ` Vivek Goyal
2011-12-19 17:35 ` Tejun Heo
2011-12-19 18:27 ` Vivek Goyal
2011-12-19 22:56 ` Tejun Heo
2011-12-20 14:50 ` Vivek Goyal
2011-12-20 20:45 ` Tejun Heo
2011-12-20 12:49 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2011-12-16 18:47 Nate Custer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219134012.GA7175@redhat.com \
--to=vgoyal@redhat.com \
--cc=avi@redhat.com \
--cc=axboe@kernel.dk \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nate@cpanel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.