From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] PXA: Kill last remnants of set_GPIO_mode function
Date: Mon, 19 Dec 2011 17:24:47 +0100 [thread overview]
Message-ID: <20111219172447.7e2c42a1@wker> (raw)
In-Reply-To: <4EEF6307.3090607@aribaud.net>
On Mon, 19 Dec 2011 17:15:03 +0100
Albert ARIBAUD <albert.u.boot@aribaud.net> wrote:
> Le 19/12/2011 16:57, Anatolij Gustschin a ?crit :
> > Hi Marek, Albert,
> >
> > On Mon, 12 Dec 2011 16:34:03 +0100
> > Marek Vasut<marek.vasut@gmail.com> wrote:
> >
> >> GPIO configuration shall never be done inside a driver, never.
> >>
> >> Signed-off-by: Marek Vasut<marek.vasut@gmail.com>
> >> Cc: Anatolij Gustschin<agust@denx.de>
> >> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
> >> ---
> >> board/lubbock/lubbock.c | 6 ++++++
> >> drivers/mmc/pxa_mmc.c | 5 -----
> >> 2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > This patch should go into v2011.12 release. Who is going
> > to apply it? Or should I push it via my staging branch?
> >
> > Thanks,
> > Anatolij
>
> How was this patch tested?
I only compile-tested it.
Marek, do you have this board? Did you test this patch on
real hardware?
Anatolij
next prev parent reply other threads:[~2011-12-19 16:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 15:15 [U-Boot] [PATCH] PXA: Fix building for lubbock board Anatolij Gustschin
2011-12-12 15:23 ` Marek Vasut
2011-12-12 15:34 ` [U-Boot] [PATCH] PXA: Kill last remnants of set_GPIO_mode function Marek Vasut
2011-12-19 15:57 ` Anatolij Gustschin
2011-12-19 16:15 ` Albert ARIBAUD
2011-12-19 16:24 ` Anatolij Gustschin [this message]
2011-12-19 16:25 ` Marek Vasut
2011-12-19 16:33 ` Wolfgang Denk
2011-12-19 16:49 ` Albert ARIBAUD
2011-12-19 17:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219172447.7e2c42a1@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.