All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Christopher Larson <chris_larson@mentor.com>,
	meta-ti@lists.yoctoproject.org
Subject: Re: [PATCH 1/5] linux.inc: If the kernel has CONFIG_KERNEL_LZO=y, it may well attempt to use the 'lzop' utility to do the lzo compression, but we should not be relying on that utility being installed on the build machine.
Date: Mon, 19 Dec 2011 14:37:49 -0500	[thread overview]
Message-ID: <20111219193749.GA6128@denix.org> (raw)
In-Reply-To: <1324311340-16981-1-git-send-email-koen@dominion.thruhere.net>

On Mon, Dec 19, 2011 at 05:15:36PM +0100, Koen Kooi wrote:
> From: Christopher Larson <chris_larson@mentor.com>

First, a minor nagging - can the commit message be a little shorter? :)

linux.inc: If the kernel has CONFIG_KERNEL_LZO=y, it may well attempt to use
the 'lzop' utility to do the lzo compression, but we should not be relying on
that utility being installed on the build machine.


> This currently affects the linux-omap4 build for omap4430-panda.
> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  recipes-kernel/linux/linux.inc |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes-kernel/linux/linux.inc b/recipes-kernel/linux/linux.inc
> index 9650e68..e8a754f 100644
> --- a/recipes-kernel/linux/linux.inc
> +++ b/recipes-kernel/linux/linux.inc
> @@ -264,3 +264,14 @@ pkg_postrm_kernel-devicetree () {
>  	cd /${KERNEL_IMAGEDEST}; update-alternatives --remove devicetree devicetree-${KERNEL_VERSION} || true
>  }
>  
> +# Automatically depend on lzop-native if CONFIG_KERNEL_LZO is enabled
> +python () {
> +    try:
> +        defconfig = bb.fetch2.localpath('file://defconfig', d)

Second, this will only work with single-config kernels. I guess we'll have to
adopt it for multi-kernel.inc later...


> +    except bb.fetch2.FetchError:
> +        pass
> +    else:
> +        if 'CONFIG_KERNEL_LZO=y\n' in open(defconfig).readlines():
> +            depends = d.getVar('DEPENDS', False)
> +            d.setVar('DEPENDS', depends + ' lzop-native')
> +}
> -- 
> 1.7.2.5
> 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
> 


  parent reply	other threads:[~2011-12-19 20:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19 16:15 [PATCH 1/5] linux.inc: If the kernel has CONFIG_KERNEL_LZO=y, it may well attempt to use the 'lzop' utility to do the lzo compression, but we should not be relying on that utility being installed on the build machine Koen Kooi
2011-12-19 16:15 ` [PATCH 2/5] ti-xdctools: update to 3.23.00.32 Koen Kooi
2011-12-19 19:40   ` Denys Dmytriyenko
2011-12-27  3:00   ` Peter Bigot
2011-12-19 16:15 ` [PATCH 3/5] ti-dspbios: update to 5.41.11.38 Koen Kooi
2011-12-19 19:41   ` Denys Dmytriyenko
2011-12-19 16:15 ` [PATCH 4/5] ti-ipc: update to 1_24_00_16 Koen Kooi
2011-12-19 19:42   ` Denys Dmytriyenko
2011-12-19 16:15 ` [PATCH 5/5] ti-sysbios: add 6.33.00.19 Koen Kooi
2011-12-19 19:42   ` Denys Dmytriyenko
2011-12-19 19:37 ` Denys Dmytriyenko [this message]
2011-12-19 23:22 ` [PATCH 1/5] linux.inc: If the kernel has CONFIG_KERNEL_LZO=y, it may well attempt to use the 'lzop' utility to do the lzo compression, but we should not be relying on that utility being installed on the build machine Andreas Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111219193749.GA6128@denix.org \
    --to=denis@denix.org \
    --cc=chris_larson@mentor.com \
    --cc=koen@dominion.thruhere.net \
    --cc=meta-ti@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.