From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH-V3 2/2] arm:omap: cleanup & split
 omap2/3/4_check_revision function
Date: Mon, 19 Dec 2011 15:51:11 -0800
Message-ID: <20111219235111.GX6464@atomide.com>
References: <1324290015-12679-1-git-send-email-hvaibhav@ti.com>
 <1324290015-12679-3-git-send-email-hvaibhav@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:60727 "EHLO
	mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753127Ab1LSXvN (ORCPT
	<rfc822;linux-omap@vger.kernel.org>); Mon, 19 Dec 2011 18:51:13 -0500
Content-Disposition: inline
In-Reply-To: <1324290015-12679-3-git-send-email-hvaibhav@ti.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com

* Vaibhav Hiremath <hvaibhav@ti.com> [111219 01:48]:
> This patch doesn't change functionality or behavior of the code
> execution; it barely cleans up the code and splits into SoC
> specific implementation for Rev ID and feature detection.

Thanks, looks good now and allows further clean-up later on.
I'll apply these into soc-part2 branch.

> @@ -495,37 +498,6 @@ static void __init omap4_check_revision(void)
>  }
> 
>  /*
> - * Try to detect the exact revision of the omap we're running on
> - */
> -void __init omap2_check_revision(void)
> -{
> -	/*
> -	 * At this point we have an idea about the processor revision set
> -	 * earlier with omap2_set_globals_tap().
> -	 */
> -	if (cpu_is_omap24xx()) {
> -		omap24xx_check_revision();
> -	} else if (cpu_is_omap34xx()) {
> -		omap3_check_revision();
> -
> -		/* TI81XX doesn't have feature register */
> -		if (!cpu_is_ti81xx())
> -			omap3_check_features();
> -		else
> -			ti81xx_check_features();
> -
> -		omap3_cpuinfo();
> -		return;
> -	} else if (cpu_is_omap44xx()) {
> -		omap4_check_revision();
> -		omap4_check_features();
> -		return;
> -	} else {
> -		pr_err("OMAP revision unknown, please fix!\n");
> -	}
> -}
> -

Nice that we can get rid of this function now :)

Tony