Re: [PATCH] imsm: make messages more understandable

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

On Fri, 16 Dec 2011 15:04:53 +0100 Lukasz Dorau <lukasz.dorau@intel.com>
wrote:

> The printed messages should be more appropriate and understandable
> for user. If maxsize is equal 0, this means there is no free space left
> on device. If size is greater than maxsize, this means there is not enough
> space to create a new volume of given size.
> 
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
>  super-intel.c |   13 ++++++++++---
>  1 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/super-intel.c b/super-intel.c
> index 3c10d29..3990d58 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -5466,9 +5466,16 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
>  	}
>  
>  	if (maxsize < size || maxsize == 0) {
> -		if (verbose)
> -			fprintf(stderr, Name ": not enough space after merge (%llu < %llu)\n",
> -				maxsize, size);
> +		if (verbose) {
> +			if (maxsize == 0)
> +				fprintf(stderr, Name ": no free space"
> +						" left on device. Aborting...\n");
> +			else
> +				fprintf(stderr, Name ": not enough space"
> +						" to create volume of given size"
> +						" (%llu < %llu). Aborting...\n",
> +						maxsize, size);
> +		}
>  		return 0;
>  	}

Applied.  Thanks.

NeilBrown


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]