All of lore.kernel.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: errata: Update the workaround for the 742231 Cortex-A9 erratum
Date: Tue, 20 Dec 2011 14:15:02 +0000	[thread overview]
Message-ID: <20111220141501.GB22161@arm.com> (raw)
In-Reply-To: <4EF04956.90006@renesas.com>

On Tue, Dec 20, 2011 at 08:37:42AM +0000, Shinya Kuribayashi wrote:
> Workaround for the 742231 erratum has been updated, which explains
> that bit #22 is required only for Cortex-A9 MPcore configuration with
> 1 single processor and the ACP present.
> 
> That means, it's not needed for the SMP kernel.
> 
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
> ---
> 
>  Since #742231 is associated with SMP, it's safe to remove bit #22
>  for now, but I'm concerned that 'MPcore + 1 processor + ACP' case
>  still remains as untreated.  Do we need to support the case?
> 
>  arch/arm/mm/proc-v7.S |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> index 2c559ac..8f8fced 100644
> --- a/arch/arm/mm/proc-v7.S
> +++ b/arch/arm/mm/proc-v7.S
> @@ -352,7 +352,6 @@ __v7_setup:
>  	teqne	r6, #0x22			@ present in r2p2
>  	mrceq	p15, 0, r10, c15, c0, 1		@ read diagnostic register
>  	orreq	r10, r10, #1 << 12		@ set bit #12
> -	orreq	r10, r10, #1 << 22		@ set bit #22
>  	mcreq	p15, 0, r10, c15, c0, 1		@ write diagnostic register

Most A9 configurations I'm aware of are indeed SMP. But maybe you could
add a !CONFIG_SMP around bit 22 setting, just in case there are
platforms using this together with an ACP.

-- 
Catalin

  reply	other threads:[~2011-12-20 14:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20  8:36 ARM errata corrections Shinya Kuribayashi
2011-12-20  8:37 ` [PATCH] ARM: errata: Update the workaround for the 742231 Cortex-A9 erratum Shinya Kuribayashi
2011-12-20 14:15   ` Catalin Marinas [this message]
2011-12-20  8:38 ` [PATCH] ARM: errata: Faulty logic in the Store Buffer may lead to data corruption Shinya Kuribayashi
2011-12-20 10:26   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111220141501.GB22161@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.