All of lore.kernel.org
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/12] clk: add helper functions clk_prepare_enable and clk_disable_unprepare
Date: Tue, 20 Dec 2011 14:48:10 +0100	[thread overview]
Message-ID: <201112201448.10577.marek.vasut@gmail.com> (raw)
In-Reply-To: <1324382443-4439-2-git-send-email-shawn.guo@linaro.org>

> From: Richard Zhao <richard.zhao@linaro.org>
> 
> It's for migrating to generic clk framework API.
> 
> The helper functions  help cases clk_enable/clk_disable is used
> in non-atomic context.
> For example, Call clk_enable in probe and clk_disable in remove.
> 
> Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Russell King <linux@arm.linux.org.uk>
> ---
>  include/linux/clk.h |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 7213b52..b9d46fa 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -107,6 +107,28 @@ static inline void clk_unprepare(struct clk *clk)
>  }
>  #endif
> 
> +/* clk_prepare_enable helps cases using clk_enable in non-atomic context.
> */ +static inline int clk_prepare_enable(struct clk *clk)
> +{
> +	int ret;
> +
> +	ret = clk_prepare(clk);
> +	if (ret)
> +		return ret;
> +	ret = clk_enable(clk);
> +	if (ret)
> +		clk_unprepare(clk);
> +
> +	return ret;
> +}
> +
> +/* clk_disable_unprepare helps cases using clk_disable in non-atomic
> context. */ +static inline void clk_disable_unprepare(struct clk *clk)
> +{
> +	clk_disable(clk);
> +	clk_unprepare(clk);
> +}
> +
>  /**
>   * clk_get_rate - obtain the current clock rate (in Hz) for a clock
> source. *		  This is only valid once the clock source has been 
enabled.

Just be sure clk_prepare() is always available (which I suspect is checked in 
the implementation, so ok). Other than that, 

Acked-by: Marek Vasut <marek.vasut@gmail.com>

  reply	other threads:[~2011-12-20 13:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20 12:00 [PATCH 0/12] Add clk_prepare/clk_unprepare for mxs clock api Shawn Guo
2011-12-20 12:00 ` [PATCH 01/12] clk: add helper functions clk_prepare_enable and clk_disable_unprepare Shawn Guo
2011-12-20 13:48   ` Marek Vasut [this message]
2011-12-20 14:09     ` Shawn Guo
2011-12-20 12:00 ` [PATCH 02/12] arm/mxs: convert platform code to clk_prepare/clk_unprepare Shawn Guo
2011-12-20 13:44   ` Marek Vasut
2011-12-20 21:11     ` Russell King - ARM Linux
2011-12-20 21:28       ` Marek Vasut
2011-12-20 12:00 ` [PATCH 03/12] net: fec: add clk_prepare/clk_unprepare Shawn Guo
2011-12-20 13:45   ` Marek Vasut
2011-12-20 12:00 ` [PATCH 04/12] dma: mxs-dma: convert to clk_prepare/clk_unprepare Shawn Guo
2011-12-20 13:45   ` Marek Vasut
2011-12-23 17:35     ` Vinod Koul
2011-12-20 12:00 ` [PATCH 05/12] mmc: mxs-mmc: " Shawn Guo
2011-12-20 13:45   ` Marek Vasut
2011-12-20 12:00 ` [PATCH 06/12] mtd: gpmi-lib: " Shawn Guo
2011-12-20 13:46   ` Marek Vasut
2011-12-20 12:00 ` [PATCH 07/12] net: flexcan: " Shawn Guo
2011-12-20 13:48   ` Marek Vasut
2011-12-20 14:23     ` Shawn Guo
2011-12-20 12:00 ` [PATCH 08/12] serial: mxs-auart: " Shawn Guo
2011-12-20 13:49   ` Marek Vasut
2011-12-20 14:07     ` Uwe Kleine-König
2011-12-20 21:15       ` Russell King - ARM Linux
2011-12-20 21:28         ` Marek Vasut
2011-12-20 22:24           ` Russell King - ARM Linux
2011-12-21  1:06             ` Marek Vasut
2011-12-20 14:27     ` Shawn Guo
2011-12-20 12:00 ` [PATCH 09/12] video: mxsfb: " Shawn Guo
2011-12-20 13:49   ` Marek Vasut
2011-12-21  2:11   ` Florian Tobias Schandinat
2011-12-20 12:00 ` [PATCH 10/12] ASoC: mxs-saif: " Shawn Guo
2011-12-20 11:55   ` Mark Brown
2011-12-20 13:49   ` Marek Vasut
2011-12-20 12:00 ` [PATCH 11/12] clk: add config option HAVE_CLK_PREPARE into Kconfig Shawn Guo
2011-12-20 12:00 ` [PATCH 12/12] arm/mxs: select HAVE_CLK_PREPARE for clock Shawn Guo
2011-12-20 13:43 ` [PATCH 0/12] Add clk_prepare/clk_unprepare for mxs clock api Marek Vasut
2011-12-20 14:05   ` Shawn Guo
2011-12-20 13:59     ` Marek Vasut
2011-12-20 14:21       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112201448.10577.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.