From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Li Zefan <lizf@cn.fujitsu.com>,
Mandeep Singh Baines <msb@chromium.org>
Subject: [GIT PULL] cgroup fixes for v3.2-rc6
Date: Tue, 20 Dec 2011 11:28:16 -0800 [thread overview]
Message-ID: <20111220192816.GF10752@google.com> (raw)
Hello, Linus.
Trying to migrating a zombie task hits BUG. This is already fixed in
the devel branch with the threadgroup locking and this is only for
v3.2 and -stable. The fix is simple - not skipping PF_EXITING tasks
in cgroup_attach_proc() preparation steps is enough.
Please pull from the following git branch to receive the fix.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.2-fixes
Thank you.
Mandeep Singh Baines (1):
cgroups: fix a css_set not found bug in cgroup_attach_proc
kernel/cgroup.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index d9d5648..a184470 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2098,11 +2098,6 @@ int cgroup_attach_proc(struct cgroup *cgrp, struct task_struct *leader)
continue;
/* get old css_set pointer */
task_lock(tsk);
- if (tsk->flags & PF_EXITING) {
- /* ignore this task if it's going away */
- task_unlock(tsk);
- continue;
- }
oldcg = tsk->cgroups;
get_css_set(oldcg);
task_unlock(tsk);
reply other threads:[~2011-12-20 19:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220192816.GF10752@google.com \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=msb@chromium.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.