From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/omap: drm API update: addfb2 Date: Wed, 21 Dec 2011 01:30:42 +0200 Message-ID: <20111220233042.GT3692@intel.com> References: <1324421933-18170-1-git-send-email-rob.clark@linaro.org> <1324421933-18170-2-git-send-email-rob.clark@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id EA8729EDD9 for ; Tue, 20 Dec 2011 15:26:50 -0800 (PST) Content-Disposition: inline In-Reply-To: <1324421933-18170-2-git-send-email-rob.clark@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: Greg KH , patches@linaro.org, dri-devel@lists.freedesktop.org, Rob Clark List-Id: dri-devel@lists.freedesktop.org On Tue, Dec 20, 2011 at 04:58:51PM -0600, Rob Clark wrote: > +static const struct format formats[] =3D { > + /* 16bpp [A]RGB: */ > + { OMAP_DSS_COLOR_RGB16, DRM_FORMAT_RGB565, {{2, 1}}, false }, /= * RGB16-565 */ > + { OMAP_DSS_COLOR_RGB12U, DRM_FORMAT_RGBX4444, {{2, 1}}, false }, /= * RGB12x-4444 */ > + { OMAP_DSS_COLOR_RGBX16, DRM_FORMAT_XRGB4444, {{2, 1}}, false }, /= * xRGB12-4444 */ > + { OMAP_DSS_COLOR_RGBA16, DRM_FORMAT_RGBA4444, {{2, 1}}, false }, /= * RGBA12-4444 */ > + { OMAP_DSS_COLOR_ARGB16, DRM_FORMAT_ABGR4444, {{2, 1}}, false }, /= * ARGB16-4444 */ ^^^^^^^^ Should be ARGB4444, no? BTW I took a quick gander at the format specifications in the OMAP4 TRM and it has a funny bug. xRGB16-1555 and ARGB16-1555 are listed like this: 31 ... 0 U R1 G1 B1 U R0 B0 G0 A1 R1 G1 B1 A0 R0 B0 G0 So every second pixel has B and G swapped around. That would be some interesting hardware to use :D It's possible the TRM I had lying around was an old one though and the issue is fixed in later revisions. -- = Ville Syrj=E4l=E4 Intel OTC