From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <syrjala@sci.fi>
Subject: Re: [PATCH 1/3] drm/omap: drm API update: addfb2
Date: Wed, 21 Dec 2011 02:34:43 +0200
Message-ID: <20111221003443.GG3028@sci.fi>
References: <1324421933-18170-1-git-send-email-rob.clark@linaro.org>
	<1324421933-18170-2-git-send-email-rob.clark@linaro.org>
	<20111220233042.GT3692@intel.com>
	<CAF6AEGtvktrf4sAvLovzivXFYONG23fcypX6kAS8LxSqxekhDQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from filtteri5.pp.htv.fi (filtteri5.pp.htv.fi [213.243.153.188])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2D7AA9EF86
	for <dri-devel@lists.freedesktop.org>;
	Tue, 20 Dec 2011 16:42:57 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CAF6AEGtvktrf4sAvLovzivXFYONG23fcypX6kAS8LxSqxekhDQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Rob Clark <rob.clark@linaro.org>
Cc: Greg KH <greg@kroah.com>, dri-devel@lists.freedesktop.org, patches@linaro.org
List-Id: dri-devel@lists.freedesktop.org

On Tue, Dec 20, 2011 at 05:58:41PM -0600, Rob Clark wrote:
> On Tue, Dec 20, 2011 at 5:30 PM, Ville Syrj=E4l=E4
> <ville.syrjala@linux.intel.com> wrote:
> > On Tue, Dec 20, 2011 at 04:58:51PM -0600, Rob Clark wrote:
> >> +static const struct format formats[] =3D {
> >> + =A0 =A0 /* 16bpp [A]RGB: */
> >> + =A0 =A0 { OMAP_DSS_COLOR_RGB16, =A0 =A0 =A0 DRM_FORMAT_RGB565, =A0 {=
{2, 1}}, false }, /* RGB16-565 */
> >> + =A0 =A0 { OMAP_DSS_COLOR_RGB12U, =A0 =A0 =A0DRM_FORMAT_RGBX4444, {{2=
, 1}}, false }, /* RGB12x-4444 */
> >> + =A0 =A0 { OMAP_DSS_COLOR_RGBX16, =A0 =A0 =A0DRM_FORMAT_XRGB4444, {{2=
, 1}}, false }, /* xRGB12-4444 */
> >> + =A0 =A0 { OMAP_DSS_COLOR_RGBA16, =A0 =A0 =A0DRM_FORMAT_RGBA4444, {{2=
, 1}}, false }, /* RGBA12-4444 */
> >> + =A0 =A0 { OMAP_DSS_COLOR_ARGB16, =A0 =A0 =A0DRM_FORMAT_ABGR4444, {{2=
, 1}}, false }, /* ARGB16-4444 */
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 =A0 =A0 =A0 =A0 =A0 ^^^^^^^^
> >
> > Should be ARGB4444, no?
> =

> yes, you are right.. I got that backwards
> =

> > BTW I took a quick gander at the format specifications in the OMAP4 TRM
> > and it has a funny bug.
> >
> > xRGB16-1555 and ARGB16-1555 are listed like this:
> >
> > 31 =A0 =A0 =A0 ... =A0 =A0 =A0 =A0 =A00
> > U =A0R1 G1 B1 U =A0R0 B0 G0
> > A1 R1 G1 B1 A0 R0 B0 G0
> >
> > So every second pixel has B and G swapped around. That would be some
> > interesting hardware to use :D
> >
> > It's possible the TRM I had lying around was an old one though and the
> > issue is fixed in later revisions.
> =

> It is still like this in the version of TRM that I have..  I've never
> really used those formats, so can't really if that is a documentation
> bug or just a weird format.  Maybe I should remove those from the
> table too until I have a chance to verify.

I was going to say that I tested them on OMAP3 when I was still @nokia,
but now that I checked again OMAP3 doesn't support the 1555 formats. It
was the 4444 formats I tested, and even exposed to users via Xv on the
N9.

-- =

Ville Syrj=E4l=E4
syrjala@sci.fi
http://www.sci.fi/~syrjala/