All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm, arm-kirkwood: disable l2c before linux boot
Date: Wed, 21 Dec 2011 02:05:43 +0100	[thread overview]
Message-ID: <201112210205.43191.marek.vasut@gmail.com> (raw)
In-Reply-To: <1324424146-6289-1-git-send-email-michael@walle.cc>

> The decompressor expects the L2 cache to be disabled. This fixes booting
> some kernels, which have CONFIG_ARM_PATCH_PHYS_VIRT enabled.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Cc: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  arch/arm/cpu/arm926ejs/cache.c           |   15 ++++++++++
>  arch/arm/cpu/arm926ejs/cpu.c             |    2 +
>  arch/arm/cpu/arm926ejs/kirkwood/Makefile |    1 +
>  arch/arm/cpu/arm926ejs/kirkwood/cache.c  |   43
> ++++++++++++++++++++++++++++++ 4 files changed, 61 insertions(+), 0
> deletions(-)
>  create mode 100644 arch/arm/cpu/arm926ejs/kirkwood/cache.c
> 
> diff --git a/arch/arm/cpu/arm926ejs/cache.c
> b/arch/arm/cpu/arm926ejs/cache.c index 4415642..7a7d0a6 100644
> --- a/arch/arm/cpu/arm926ejs/cache.c
> +++ b/arch/arm/cpu/arm926ejs/cache.c
> @@ -73,3 +73,18 @@ void  flush_cache(unsigned long start, unsigned long
> size) {
>  }
>  #endif /* #ifndef CONFIG_SYS_DCACHE_OFF */
> +
> +/*
> + * Stub implementations for l2 cache operations
> + */
> +void __l2_cache_enable(void)
> +{
> +}
> +void l2_cache_enable(void)
> +        __attribute__((weak, alias("__l2_cache_enable")));
> +
> +void __l2_cache_disable(void)
> +{
> +}
> +void l2_cache_disable(void)
> +        __attribute__((weak, alias("__l2_cache_disable")));
> diff --git a/arch/arm/cpu/arm926ejs/cpu.c b/arch/arm/cpu/arm926ejs/cpu.c
> index 5c902df..626384c 100644
> --- a/arch/arm/cpu/arm926ejs/cpu.c
> +++ b/arch/arm/cpu/arm926ejs/cpu.c
> @@ -50,6 +50,8 @@ int cleanup_before_linux (void)
>  	/* turn off I/D-cache */
>  	icache_disable();
>  	dcache_disable();
> +	l2_cache_disable();
> +
>  	/* flush I/D-cache */
>  	cache_flush();
> 
> diff --git a/arch/arm/cpu/arm926ejs/kirkwood/Makefile
> b/arch/arm/cpu/arm926ejs/kirkwood/Makefile index 0754297..777006c 100644
> --- a/arch/arm/cpu/arm926ejs/kirkwood/Makefile
> +++ b/arch/arm/cpu/arm926ejs/kirkwood/Makefile
> @@ -30,6 +30,7 @@ COBJS-y	= cpu.o
>  COBJS-y	+= dram.o
>  COBJS-y	+= mpp.o
>  COBJS-y	+= timer.o
> +COBJS-y	+= cache.o
> 
>  SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
>  OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS-y))
> diff --git a/arch/arm/cpu/arm926ejs/kirkwood/cache.c
> b/arch/arm/cpu/arm926ejs/kirkwood/cache.c new file mode 100644
> index 0000000..df90cb9
> --- /dev/null
> +++ b/arch/arm/cpu/arm926ejs/kirkwood/cache.c
> @@ -0,0 +1,43 @@
> +/*
> + * Copyright (c) 2011 Michael Walle
> + * Michael Walle <michael@walle.cc>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc.
> + */
> +#include <common.h>
> +#include <asm/arch/cpu.h>
> +
> +#define FEROCEON_EXTRA_FEATURE_L2C_EN (1<<22)
> +
> +void l2_cache_enable()
> +{
> +	u32 ctrl;
> +
> +	ctrl = readfr_extra_feature_reg();
> +	ctrl |= FEROCEON_EXTRA_FEATURE_L2C_EN;
> +	writefr_extra_feature_reg(ctrl);
> +}
> +
> +void l2_cache_disable()
> +{
> +	u32 ctrl;
> +
> +	ctrl = readfr_extra_feature_reg();
> +	ctrl &= ~FEROCEON_EXTRA_FEATURE_L2C_EN;
> +	writefr_extra_feature_reg(ctrl);
> +}

Fine by me ...

Acked-by: Marek Vasut <marek.vasut@gmail.com>

  reply	other threads:[~2011-12-21  1:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-18 22:09 [U-Boot] [PATCH] arm, arm-kirkwood: disable l2c before linux boot Michael Walle
2011-12-18 22:19 ` Michael Walle
2011-12-18 23:04 ` Marek Vasut
2011-12-18 23:21   ` Michael Walle
2011-12-20  7:04     ` Albert ARIBAUD
2011-12-20 23:37       ` Michael Walle
2011-12-20 23:35   ` Michael Walle
2011-12-21  1:05     ` Marek Vasut [this message]
2012-01-02 18:37     ` Michael Walle
2012-01-12 22:44       ` Albert ARIBAUD
2012-01-13 22:53   ` [U-Boot] [PATCH v2] " Michael Walle
2012-01-13 22:59     ` Michael Walle
2012-01-31 22:49       ` Michael Walle
2012-01-31 23:04         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112210205.43191.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.