From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board Date: Wed, 21 Dec 2011 16:24:17 +0800 Message-ID: <20111221082416.GA20153@localhost> References: <20111221022020.GA20195@localhost> <20111221072314.GA10669@localhost> <4EF19440.10801@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by alsa0.perex.cz (Postfix) with ESMTP id 21DEF24336 for ; Wed, 21 Dec 2011 09:24:21 +0100 (CET) Content-Disposition: inline In-Reply-To: <4EF19440.10801@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: David Henningsson Cc: Takashi Iwai , "alsa-devel@alsa-project.org" List-Id: alsa-devel@alsa-project.org On Wed, Dec 21, 2011 at 04:09:36PM +0800, David Henningsson wrote: > On 12/21/2011 08:23 AM, Wu Fengguang wrote: > > On Wed, Dec 21, 2011 at 02:46:32PM +0800, Takashi Iwai wrote: > >> I'm in the process removing all these model quirks. > > > > Doesn't that risk introducing many regressions? What would be the > > problem if we switch to the generic HDA driver for *new* boards and > > leave the old working quicks/models untouched? > > For me, it's the other way around. Whenever we try to improve the > generic behaviour of the codec driver, e g by adding configurable > auto-mute, jack detection notification etc, these old models get left > behind because the new stuff depends on information we get out of the > autoparser(s). > > By removing the model quirks, these machines can benefit from the new > functionality as well. Yeah that's a good point of view! I cannot agree it any more. Thanks, Fengguang