Re: iwl3945 firmware errors: tentative debugging

[Stanislaw Gruszka <sgruszka@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

Hi Pedro,

On Tue, Nov 29, 2011 at 05:07:55PM +0000, Pedro Francisco wrote:
> My country has the following regulatory.bin lines:
> 
> country PT:	(2402.000 - 2482.000 @ 40.000), (N/A, 20.00)	(5170.000 -
> 5250.000 @ 40.000), (N/A, 20.00)	(5250.000 - 5330.000 @ 40.000), (N/A,
> 20.00), DFS <------ removed whole line	(5490.000 - 5710.000 @ 40.000),
> (N/A, 27.00), DFS <------ removed whole line
> 
> If I remove the last two lines, everything works as expected, i.e., NO
> "Microsode SW error". If I include any of the last two, the Microcode
> will issue an error.
> 
> I've tried every combination of those lines except just one of
> "(5250.000 - 5330.000 @ 40.000), (N/A, 20.00), DFS" OR "(5490.000 -
> 5710.000 @ 40.000), (N/A, 27.00), DFS".

Attached patch stop to trigger error on my setup with "iw dev wlan0 scan
passive". Can you check if it also fix problem on your normal wireless
workload?

Thanks
Stanislaw

[-- Attachment #2: iwlegacy-do-not-promote-to-active-scan-on-transmistion-detect.patch --]
[-- Type: text/plain, Size: 911 bytes --]

diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c
index daef6b5..b6df518 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
@@ -2624,12 +2624,12 @@ il3945_request_scan(struct il_priv *il, struct ieee80211_vif *vif)
 	}
 
 	/*
-	 * If active scaning is requested but a certain channel
-	 * is marked passive, we can do active scanning if we
-	 * detect transmissions.
+	 * If active scaning is requested but a certain channel is marked
+	 * passive, we can do active scanning if we detect transmissions. For
+	 * passive only scanning disable switching to active on any channel.
 	 */
 	scan->good_CRC_th =
-	    is_active ? IL_GOOD_CRC_TH_DEFAULT : IL_GOOD_CRC_TH_DISABLED;
+	    is_active ? IL_GOOD_CRC_TH_DEFAULT : IL_GOOD_CRC_TH_NEVER;
 
 	len =
 	    il_fill_probe_req(il, (struct ieee80211_mgmt *)scan->data,