From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/device/dev-cache.c
Date: 21 Dec 2011 13:21:09 -0000 [thread overview]
Message-ID: <20111221132109.10681.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2011-12-21 13:21:09
Modified files:
. : WHATS_NEW
lib/device : dev-cache.c
Log message:
Do not lstat common path prefix
When both path have identical prefix i.e. /dev/disk/by-id
skip 2 x lstat() for /dev /dev/disk /dev/disk/by-id
and directly lstat() only different part of the path.
Reduces amount of lstat calls on system with lots of devices.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2211&r2=1.2212
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/device/dev-cache.c.diff?cvsroot=lvm2&r1=1.68&r2=1.69
--- LVM2/WHATS_NEW 2011/12/21 13:17:54 1.2211
+++ LVM2/WHATS_NEW 2011/12/21 13:21:09 1.2212
@@ -1,5 +1,6 @@
Version 2.02.89 -
==================================
+ Reduce number of lstat calls when selecting device alias.
Add function to inialize common structure device members.
Always zalloc device structure during initialization.
Fix missing thread list manipulation protection in dmeventd.
--- LVM2/lib/device/dev-cache.c 2011/12/21 13:17:54 1.68
+++ LVM2/lib/device/dev-cache.c 2011/12/21 13:21:09 1.69
@@ -259,6 +259,13 @@
s0 = &p0[0] + 1;
s1 = &p1[0] + 1;
+ /*
+ * If we reach here, both paths are the same length.
+ * Now skip past identical path components.
+ */
+ while (*s0 && *s0 == *s1)
+ s0++, s1++;
+
/* We prefer symlinks - they exist for a reason!
* So we prefer a shorter path before the first symlink in the name.
* FIXME Configuration option to invert this? */
next reply other threads:[~2011-12-21 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 13:21 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-11 9:12 LVM2 ./WHATS_NEW lib/device/dev-cache.c prajnoha
2011-12-21 13:17 zkabelac
2011-12-21 13:14 zkabelac
2011-01-17 15:16 zkabelac
2010-05-24 22:53 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221132109.10681.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.