From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/device/dev-io.c
Date: 21 Dec 2011 13:24:25 -0000 [thread overview]
Message-ID: <20111221132425.11606.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2011-12-21 13:24:25
Modified files:
. : WHATS_NEW
lib/device : dev-io.c
Log message:
Drop extra stat before open of device
Since the !(dev->flags & DEV_REGULAR) code path just called
dev_name_confirmed() which has just called 'stat()' inside,
remove duplicate second stat() call here.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2212&r2=1.2213
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/device/dev-io.c.diff?cvsroot=lvm2&r1=1.78&r2=1.79
--- LVM2/WHATS_NEW 2011/12/21 13:21:09 1.2212
+++ LVM2/WHATS_NEW 2011/12/21 13:24:24 1.2213
@@ -1,5 +1,6 @@
Version 2.02.89 -
==================================
+ Drop extra stat call before opening device.
Reduce number of lstat calls when selecting device alias.
Add function to inialize common structure device members.
Always zalloc device structure during initialization.
--- LVM2/lib/device/dev-io.c 2011/05/28 09:48:14 1.78
+++ LVM2/lib/device/dev-io.c 2011/12/21 13:24:25 1.79
@@ -449,17 +449,6 @@
else if (!(name = dev_name_confirmed(dev, quiet)))
return_0;
- if (!(dev->flags & DEV_REGULAR)) {
- if (stat(name, &buf) < 0) {
- log_sys_error("%s: stat failed", name);
- return 0;
- }
- if (buf.st_rdev != dev->dev) {
- log_error("%s: device changed", name);
- return 0;
- }
- }
-
#ifdef O_DIRECT_SUPPORT
if (direct) {
if (!(dev->flags & DEV_O_DIRECT_TESTED))
next reply other threads:[~2011-12-21 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 13:24 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-22 22:31 LVM2 ./WHATS_NEW lib/device/dev-io.c agk
2007-09-07 11:24 meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221132425.11606.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.