All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Yogesh Ashok Powar <yogeshp@marvell.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Nishant Sarmukadam <nishants@marvell.com>
Subject: Re: [PATCH] mac80211: Call driver commands after drv_start in mac80211 restart code
Date: Wed, 21 Dec 2011 14:28:11 +0100	[thread overview]
Message-ID: <20111221132810.GB2235@redhat.com> (raw)
In-Reply-To: <20111220060505.GA4556@hertz.marvell.com>

On Tue, Dec 20, 2011 at 11:35:16AM +0530, Yogesh Ashok Powar wrote:
> Ideally, hardware/firmware initialization is complete after the
> drv_start routine. In mac80211 restart code (ieee80211_reconfig),
> defer calling the driver commands i.e. setup fragmentation
> threshold, rts threshold and coverage class till drv_start
> routine is called.

I think this could break drivers that could relay on order we
have at present. Also chenglog does not tell much. What for you
need that change?

> +	/* reset coverage class */
> +	drv_set_coverage_class(local, hw->wiphy->coverage_class);
> +
> +
One extra empty line.

Stanislaw

  reply	other threads:[~2011-12-21 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20  6:05 [PATCH] mac80211: Call driver commands after drv_start in mac80211 restart code Yogesh Ashok Powar
2011-12-21 13:28 ` Stanislaw Gruszka [this message]
2011-12-22  6:08   ` Yogesh Ashok Powar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111221132810.GB2235@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nishants@marvell.com \
    --cc=yogeshp@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.