From: Christoph Hellwig <hch@lst.de>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <JBottomley@Parallels.com>,
Roland Dreier <roland@purestorage.com>,
Joern Engel <joern@logfs.org>,
Madhuranath Iyengar <mni@risingtidesystems.com>
Subject: Re: [RFC-v4 0/3] qla2xxx: v3.4 target mode LLD changes + tcm_qla2xxx fabric module
Date: Wed, 21 Dec 2011 18:11:35 +0100 [thread overview]
Message-ID: <20111221171135.GA27369@lst.de> (raw)
In-Reply-To: <1324173746-14361-1-git-send-email-nab@linux-iscsi.org>
I think the most important item is to sort out the mess around the old
generation qla23xx support. The way the code currently sprinkles ifs
around that is a complete mess. Given that the qla23xx support has as
far as I know zero test coverage, and has been EOLed by qlogic I see
no reason to keep it around.
Anyone disagreeing with that?
The other bit is sorting out handling of the full command queues in the
hardware. Currently the target core does a blind retry after some delay,
which isn't a good idea. I had an RFC patch on how to move it into the
driver, but I'll really need some help to find the proper place to wake
up any process waiting once we get free slots.
next prev parent reply other threads:[~2011-12-21 17:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 2:02 [RFC-v4 0/3] qla2xxx: v3.4 target mode LLD changes + tcm_qla2xxx fabric module Nicholas A. Bellinger
2011-12-18 2:02 ` [RFC-v4 1/3] qla2xxx: Add LLD internal target-mode support Nicholas A. Bellinger
2011-12-19 22:59 ` Roland Dreier
2011-12-21 21:48 ` Nicholas A. Bellinger
2011-12-21 22:46 ` Roland Dreier
2011-12-18 2:02 ` [RFC-v4 2/3] qla2xxx: Enable 2xxx series LLD target mode support Nicholas A. Bellinger
2011-12-18 2:02 ` [RFC-v4 3/3] qla2xxx: Add tcm_qla2xxx fabric module for mainline target Nicholas A. Bellinger
2011-12-22 8:10 ` Roland Dreier
2011-12-23 21:51 ` Nicholas A. Bellinger
2012-01-02 21:38 ` Roland Dreier
2012-01-10 0:24 ` Nicholas A. Bellinger
2011-12-21 17:11 ` Christoph Hellwig [this message]
2011-12-22 22:25 ` [RFC-v4 0/3] qla2xxx: v3.4 target mode LLD changes + tcm_qla2xxx fabric module Andrew Vasquez
2011-12-23 21:59 ` Nicholas A. Bellinger
-- strict thread matches above, loose matches on Subject: below --
2012-05-13 15:55 Bart Van Assche
2012-05-14 3:29 ` Nicholas A. Bellinger
2012-05-14 12:50 ` Bart Van Assche
2012-05-14 23:12 ` Nicholas A. Bellinger
2012-05-15 14:21 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221171135.GA27369@lst.de \
--to=hch@lst.de \
--cc=JBottomley@Parallels.com \
--cc=andrew.vasquez@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mni@risingtidesystems.com \
--cc=nab@linux-iscsi.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.