From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/3 v5] sound/soc/codecs: add LAPIS Semiconductor ML26124 Date: Thu, 22 Dec 2011 10:50:00 +0000 Message-ID: <20111222104959.GB4546@opensource.wolfsonmicro.com> References: <1324349144-12784-1-git-send-email-tomoya.rohm@gmail.com> <20111220104047.GE2866@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id DA065244A7 for ; Thu, 22 Dec 2011 11:50:03 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Tomoya MORINAGA Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Lars-Peter Clausen , Mike Frysinger , qi.wang@intel.com, Takashi Iwai , linux-kernel@vger.kernel.org, yong.y.wang@intel.com, kok.howg.ewe@intel.com, Daniel Mack , Liam Girdwood , joel.clark@intel.com List-Id: alsa-devel@alsa-project.org On Thu, Dec 22, 2011 at 05:31:08PM +0900, Tomoya MORINAGA wrote: > 2011/12/20 Mark Brown : > > How have you tested this code? > No, I haven't tested at all. (Of course, I tested before ASoC.) > I'll test the new these drivers after you say "Roughly, how to use > ASoC framework is OK" Don't do this unless you really have to, and if for some reason it's needed or useful then indicate that this is what you're doing. People shouldn't be finding issues on review that mean that the code will never run. If the testing is very light that's fine but you need to make some effort to verify that things will work. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755175Ab1LVKuG (ORCPT ); Thu, 22 Dec 2011 05:50:06 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:40831 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416Ab1LVKuE (ORCPT ); Thu, 22 Dec 2011 05:50:04 -0500 Date: Thu, 22 Dec 2011 10:50:00 +0000 From: Mark Brown To: Tomoya MORINAGA Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Dimitris Papastamos , Mike Frysinger , Daniel Mack , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com Subject: Re: [PATCH 1/3 v5] sound/soc/codecs: add LAPIS Semiconductor ML26124 Message-ID: <20111222104959.GB4546@opensource.wolfsonmicro.com> References: <1324349144-12784-1-git-send-email-tomoya.rohm@gmail.com> <20111220104047.GE2866@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You are always busy. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 22, 2011 at 05:31:08PM +0900, Tomoya MORINAGA wrote: > 2011/12/20 Mark Brown : > > How have you tested this code? > No, I haven't tested at all. (Of course, I tested before ASoC.) > I'll test the new these drivers after you say "Roughly, how to use > ASoC framework is OK" Don't do this unless you really have to, and if for some reason it's needed or useful then indicate that this is what you're doing. People shouldn't be finding issues on review that mean that the code will never run. If the testing is very light that's fine but you need to make some effort to verify that things will work.