From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Slusarz Subject: Re: [PATCH] drm/nouveau: fix acpi related kbuild warnings Date: Thu, 22 Dec 2011 17:54:34 +0100 Message-ID: <20111222165434.GA6111@joi.lan> References: <20111102213940.GA5459@joi.lan> <20111109213234.GB3402@joi.lan> <20111202184914.GB3302@joi.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20111202184914.GB3302-OI9uyE9O0yo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Ben Skeggs Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org On Fri, Dec 02, 2011 at 07:49:14PM +0100, Marcin Slusarz wrote: > On Wed, Nov 09, 2011 at 10:32:34PM +0100, Marcin Slusarz wrote: > > On Wed, Nov 02, 2011 at 10:39:40PM +0100, Marcin Slusarz wrote: > > > Currently when X86 && ACPI && !X86_PLATFORM_DEVICES kbuild spits: > > > > > > warning: (DRM_NOUVEAU) selects ACPI_WMI which has unmet direct > > > dependencies (X86 && X86_PLATFORM_DEVICES && ACPI) > > > warning: (DRM_NOUVEAU) selects MXM_WMI which has unmet direct > > > dependencies (X86 && X86_PLATFORM_DEVICES && ACPI_WMI) > > > > > > and goes on, which leaves a situation where ACPI_WMI (which depends on > > > X86_PLATFORM_DEVICES) is enabled but X86_PLATFORM_DEVICES is not. > > > Additionally, Nouveau on IA64 would enable these X86-related drivers > > > when ACPI is enabled (doesn't matter but is wrong) and build > > > nouveau_acpi.c which depends on them. > > > > > > To fix this, introduce hidden DRM_NOUVEAU_ACPI variable which selects > > > all acpi/x86 related configs and select it when both X86 and ACPI are > > > enabled. > > > > > > Signed-off-by: Marcin Slusarz > > > --- > > ping? ping