All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org,
	Matt Fleming <matt.fleming@intel.com>,
	sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/2] sparc: Make SA_NOMASK a synonym of SA_NODEFER
Date: Thu, 22 Dec 2011 18:02:43 +0000	[thread overview]
Message-ID: <20111222180142.GA5502@redhat.com> (raw)
In-Reply-To: <1324493221-4435-2-git-send-email-matt@console-pimps.org>

On 12/21, Matt Fleming wrote:
>
> Unlike other architectures, sparc currently has no SA_NODEFER
> definition but only the older SA_NOMASK. Since SA_NOMASK is the
> historical name for SA_NODEFER, add SA_NODEFER and copy what other
> architectures do by making SA_NOMASK a synonym for SA_NODEFER.

Without this patch arch/sparc can't use the new helper from 2/2

Acked-by: Oleg Nesterov <oleg@redhat.com>

> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> ---
>  arch/sparc/include/asm/signal.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/sparc/include/asm/signal.h b/arch/sparc/include/asm/signal.h
> index e49b828..aa42fe3 100644
> --- a/arch/sparc/include/asm/signal.h
> +++ b/arch/sparc/include/asm/signal.h
> @@ -143,10 +143,11 @@ struct sigstack {
>  #define SA_ONSTACK	_SV_SSTACK
>  #define SA_RESTART	_SV_INTR
>  #define SA_ONESHOT	_SV_RESET
> -#define SA_NOMASK	0x20u
> +#define SA_NODEFER	0x20u
>  #define SA_NOCLDWAIT    0x100u
>  #define SA_SIGINFO      0x200u
>  
> +#define SA_NOMASK	SA_NODEFER
>  
>  #define SIG_BLOCK          0x01	/* for blocking signals */
>  #define SIG_UNBLOCK        0x02	/* for unblocking signals */
> -- 
> 1.7.4.4
> 


WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org,
	Matt Fleming <matt.fleming@intel.com>,
	sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/2] sparc: Make SA_NOMASK a synonym of SA_NODEFER
Date: Thu, 22 Dec 2011 19:02:43 +0100	[thread overview]
Message-ID: <20111222180142.GA5502@redhat.com> (raw)
In-Reply-To: <1324493221-4435-2-git-send-email-matt@console-pimps.org>

On 12/21, Matt Fleming wrote:
>
> Unlike other architectures, sparc currently has no SA_NODEFER
> definition but only the older SA_NOMASK. Since SA_NOMASK is the
> historical name for SA_NODEFER, add SA_NODEFER and copy what other
> architectures do by making SA_NOMASK a synonym for SA_NODEFER.

Without this patch arch/sparc can't use the new helper from 2/2

Acked-by: Oleg Nesterov <oleg@redhat.com>

> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> ---
>  arch/sparc/include/asm/signal.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/sparc/include/asm/signal.h b/arch/sparc/include/asm/signal.h
> index e49b828..aa42fe3 100644
> --- a/arch/sparc/include/asm/signal.h
> +++ b/arch/sparc/include/asm/signal.h
> @@ -143,10 +143,11 @@ struct sigstack {
>  #define SA_ONSTACK	_SV_SSTACK
>  #define SA_RESTART	_SV_INTR
>  #define SA_ONESHOT	_SV_RESET
> -#define SA_NOMASK	0x20u
> +#define SA_NODEFER	0x20u
>  #define SA_NOCLDWAIT    0x100u
>  #define SA_SIGINFO      0x200u
>  
> +#define SA_NOMASK	SA_NODEFER
>  
>  #define SIG_BLOCK          0x01	/* for blocking signals */
>  #define SIG_UNBLOCK        0x02	/* for unblocking signals */
> -- 
> 1.7.4.4
> 


  parent reply	other threads:[~2011-12-22 18:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21 18:46 [PATCH 0/2] block_sigmask() helper function Matt Fleming
2011-12-21 18:47 ` [PATCH 1/2] sparc: Make SA_NOMASK a synonym of SA_NODEFER Matt Fleming
2011-12-21 20:31   ` David Miller
2011-12-21 20:31     ` David Miller
2011-12-22 18:02   ` Oleg Nesterov [this message]
2011-12-22 18:02     ` Oleg Nesterov
2011-12-21 18:47 ` [PATCH 2/2] signal: Add block_sigmask() for adding sigmask to current->blocked Matt Fleming
2011-12-22 17:52   ` Oleg Nesterov
2011-12-22 17:51 ` [PATCH 0/2] block_sigmask() helper function Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111222180142.GA5502@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matt@console-pimps.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.