All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Samuel <chris@csamuel.org>
To: linux-btrfs@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE
Date: Thu, 22 Dec 2011 23:24:13 +1100	[thread overview]
Message-ID: <201112222324.16871.chris@csamuel.org> (raw)
In-Reply-To: <1301665083-sup-3969@think>

[-- Attachment #1: Type: Text/Plain, Size: 1951 bytes --]

Christoph,

On Sat, 2 Apr 2011 12:40:11 AM Chris Mason wrote:

> Excerpts from Christoph Hellwig's message of 2011-04-01 09:34:05 
-0400:
>
> > I don't think it's a good idea to introduce any user visible
> > operations over subvolume boundaries.  Currently we don't have
> > any operations over mount boundaries, which is pretty
> > fumdamental to the unix filesystem semantics.  If you want to
> > change this please come up with a clear description of the
> > semantics and post it to linux-fsdevel for discussion.  That of
> > course requires a clear description of the btrfs subvolumes,
> > which is still completely missing.
> 
> The subvolume is just a directory tree that can be snapshotted, and
> has it's own private inode number space.
> 
> reflink across subvolumes is no different from copying a file from
> one subvolume to another at the VFS level.  The src and
> destination are different files and different inodes, they just
> happen to share data extents.

Were Chris Mason's points above enough to sway your opposition to this 
functionality/patch?

There is demand for the ability to move data between subvolumes 
without needing to copy the extents themselves, it's cropped up again 
on the list in recent days.

It seems a little hard (and counterintuitive) to enforce a wasteful 
use of resources to copy data between different parts of the same 
filesystem which happen to be a on a different subvolume when it's 
permitted & functional to the same filesystem on the same subvolume.

I don't dispute the comment about documentation on subvolumes though, 
there is a short discussion of them on the btrfs wiki in the sysadmins 
guide, but not really a lot of detail. :-)

All the best,
Chris
-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC

This email may come with a PGP signature as a file. Do not panic.
For more info see: http://en.wikipedia.org/wiki/OpenPGP

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 482 bytes --]

  parent reply	other threads:[~2011-12-22 12:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31  4:00 [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE Larry D'Anna
2011-03-31  4:00 ` [PATCH 1/2] btrfs: remove unused argument 'root' from btrfs_release_path Larry D'Anna
2011-03-31  4:00 ` [PATCH 2/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE Larry D'Anna
2011-03-31  6:36 ` [PATCH 0/2] " Christoph Hellwig
2011-03-31  6:44   ` Arne Jansen
2011-03-31 12:02   ` Chris Mason
2011-04-01 13:34     ` Christoph Hellwig
2011-04-01 13:40       ` Chris Mason
2011-04-02  1:59         ` Fajar A. Nugraha
2011-12-22 12:24         ` Chris Samuel [this message]
2012-01-06 12:04           ` Konstantinos Skarlatos
2012-01-06 17:57             ` David Sterba
2012-01-09  6:58               ` Marios Titas
2012-01-09 13:31                 ` Jérôme Poulin
2012-01-19 16:52                   ` Jérôme Poulin
2011-04-02 15:51       ` Ken Drummond
2011-04-02 16:56         ` Larry D'Anna
2011-04-02 20:01           ` Jérôme Poulin
  -- strict thread matches above, loose matches on Subject: below --
2011-03-31 11:12 Tomasz Chmielewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112222324.16871.chris@csamuel.org \
    --to=chris@csamuel.org \
    --cc=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.