From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Antipov <dmitry.antipov@linaro.org>
Cc: linaro-dev@lists.linaro.org, patches@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: use usleep_range() instead of mdelay()/udelay()
Date: Fri, 23 Dec 2011 15:31:29 +0000 [thread overview]
Message-ID: <20111223153129.GC13175@sirena.org.uk> (raw)
In-Reply-To: <4EF18515.9030800@linaro.org>
On Wed, Dec 21, 2011 at 11:04:53AM +0400, Dmitry Antipov wrote:
> From 00753f3d48c4b6c45c1778c3e37bc9949ed79e77 Mon Sep 17 00:00:00 2001
> From: Dmitry Antipov <dmitry.antipov@linaro.org>
> Date: Wed, 21 Dec 2011 11:01:42 +0400
> Subject: [PATCH] regulator: use usleep_range() instead of mdelay()/udelay()
Follow the instructions in Documentation/SubmittingPatches.
> - if (delay >= 1000) {
> - mdelay(delay / 1000);
> - udelay(delay % 1000);
> - } else if (delay) {
> - udelay(delay);
> - }
> + usleep_range(delay, delay + 1000);
These two aren't obviously equivalent in several respects and you
haven't provided any explanation for what you're trying to accomplish.
prev parent reply other threads:[~2011-12-23 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 7:04 [PATCH] regulator: use usleep_range() instead of mdelay()/udelay() Dmitry Antipov
2011-12-23 15:31 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111223153129.GC13175@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.antipov@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.